JBEHAVE-1405 Fix invalid Json generation in case of Pending steps #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tatsiana-Luchonak
force-pushed
the
JBEHAVE-1405_fix
branch
2 times, most recently
from
529df73
to
550a0f1
Compare
uarlouski
reviewed
Oct 25, 2022
jbehave-core/src/main/java/org/jbehave/core/reporters/StoryReporter.java
Show resolved
Hide resolved
uarlouski
reviewed
Oct 25, 2022
jbehave-core/src/main/java/org/jbehave/core/reporters/StoryReporter.java
Show resolved
Hide resolved
uarlouski
reviewed
Oct 25, 2022
jbehave-core/src/main/java/org/jbehave/core/embedder/PerformableTree.java
Outdated
Show resolved
Hide resolved
valfirst
reviewed
Oct 25, 2022
jbehave-core/src/main/java/org/jbehave/core/reporters/PrintStreamOutput.java
Outdated
Show resolved
Hide resolved
Tatsiana-Luchonak
force-pushed
the
JBEHAVE-1405_fix
branch
from
550a0f1
to
e0a7423
Compare
Tatsiana-Luchonak
requested review from
valfirst and
uarlouski
and removed request for
valfirst and
uarlouski
Tatsiana-Luchonak
force-pushed
the
JBEHAVE-1405_fix
branch
2 times, most recently
from
2a7cd17
to
30fc395
Compare
uarlouski
reviewed
Oct 27, 2022
jbehave-core/src/main/java/org/jbehave/core/reporters/PostStoryStatisticsCollector.java
Outdated
Show resolved
Hide resolved
uarlouski
approved these changes
Oct 27, 2022
Tatsiana-Luchonak
force-pushed
the
JBEHAVE-1405_fix
branch
from
30fc395
to
05f4be1
Compare
Tatsiana-Luchonak
requested review from
uarlouski and
valfirst
and removed request for
valfirst and
uarlouski
|
@valfirst @ikalinin1 Could you please take a look? |
valfirst
reviewed
Nov 1, 2022
jbehave-core/src/main/java/org/jbehave/core/junit/JUnit4StoryReporter.java
Outdated
Show resolved
Hide resolved
valfirst
requested changes
Nov 1, 2022
jbehave-core/src/main/java/org/jbehave/core/model/TableTransformers.java
Outdated
Show resolved
Hide resolved
jbehave-core/src/main/java/org/jbehave/core/parsers/RegexStoryParser.java
Outdated
Show resolved
Hide resolved
jbehave-core/src/main/java/org/jbehave/core/reporters/NullStoryReporter.java
Show resolved
Hide resolved
jbehave-core/src/main/java/org/jbehave/core/reporters/PostStoryStatisticsCollector.java
Outdated
Show resolved
Hide resolved
jbehave-core/src/main/java/org/jbehave/core/reporters/SilentSuccessFilter.java
Outdated
Show resolved
Hide resolved
jbehave-core/src/test/java/org/jbehave/core/steps/ParameterConvertersBehaviour.java
Outdated
Show resolved
Hide resolved
jbehave-core/src/test/java/org/jbehave/core/steps/ParameterConvertersBehaviour.java
Outdated
Show resolved
Hide resolved
jbehave-core/src/test/java/org/jbehave/core/steps/StepCreatorBehaviour.java
Outdated
Show resolved
Hide resolved
jbehave-core/src/test/java/org/jbehave/core/steps/StepCreatorBehaviour.java
Outdated
Show resolved
Hide resolved
jbehave-core/src/main/java/org/jbehave/core/steps/StepCreator.java
Outdated
Show resolved
Hide resolved
Tatsiana-Luchonak
force-pushed
the
JBEHAVE-1405_fix
branch
from
05f4be1
to
cc01170
Compare
Tatsiana-Luchonak
requested review from
valfirst
and removed request for
ikalinin1 and
uarlouski
ikalinin1
approved these changes
Nov 3, 2022
valfirst
requested changes
Nov 3, 2022
jbehave-core/src/main/java/org/jbehave/core/reporters/XmlOutput.java
Outdated
Show resolved
Hide resolved
Tatsiana-Luchonak
force-pushed
the
JBEHAVE-1405_fix
branch
from
cc01170
to
cf3d2b7
Compare
|
The changes are cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.