JBEHAVE-1580 Add ability to convert parameters to particular type #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uarlouski
force-pushed
the
JBEHAVE-1580
branch
2 times, most recently
from
d9e78e6
to
72a7686
Compare
valfirst
requested changes
May 25, 2023
| @@ -50,6 +50,11 @@ public <T> T valueAs(String name, Type type) { | |||
| return convert(valueFor(name), type); | |||
| } | |||
|
|
|||
| @Override | |||
| public <T> T valueAs(Type type) { | |||
There was a problem hiding this comment.
Suggested change
| public <T> T valueAs(Type type) { | |
| public <T> T as(Type type) { |
| @@ -354,34 +355,44 @@ private static Object applyConverters(Object value, Type basicType, Queue<Parame | |||
| (v, c) -> c.convertValue(v, c.getTargetType()), (l, r) -> l); | |||
| } | |||
|
|
|||
| @SuppressWarnings({ "unchecked", "rawtypes" }) | |||
| public Object convertFromType(Object value, Type target) { | |||
There was a problem hiding this comment.
Suggested change
| public Object convertFromType(Object value, Type target) { | |
| public Object convert(Object value, Type target) { |
?
| return convertersChain; | ||
| } | ||
|
|
||
| private void putConverters(Type type, LinkedList<ParameterConverter> container) { | ||
| private void putConverters(Type type, LinkedList<ParameterConverter> container, | ||
| Function<Type, Boolean> baseTypeChecker) { |
There was a problem hiding this comment.
Suggested change
| Function<Type, Boolean> baseTypeChecker) { | |
| Predicate<Type> sourceTypePredicate) { |
uarlouski
force-pushed
the
JBEHAVE-1580
branch
4 times, most recently
from
e408d95
to
bca274f
Compare
valfirst
requested changes
May 25, 2023
|
|
||
| <script type="syntaxhighlighter" class="brush: java"> | ||
| <
|
Kudos, SonarCloud Quality Gate passed! |
valfirst
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.