-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhanced set_resolved_url() function, include bug fix. #68
Conversation
…eded=False. prevent auto-calling plugin.finish() by set flag, which should not be called when setResolvedUrl get called.
I had some changes for set_resolved_url locally that I hadn't pushed yet. It now takes a item (dict or xbmcswift2.Listitem) or a url optionally. If you pass an item, you can set the "properties" key to contain any properties you like, such as mimetype. |
mimetype is an important property for set_resolved_url. |
Being able to pass a rich listitem (including title, thumb) to set_resolved_url would have another benefit, but I'm not sure if xbmc pays attention to additional info labels. Problem: When using smartphone apps like YATSE you can browse the plugins VFS (independently from the XBMC GUI). The problem is when you start playback from such an app, XBMC never got the original listitem. So the fullscreen OSD shows no correct title/thumb. |
sure, it should be better if it can accept listitem also, I just want to keep function usage as simple as possible for the most common usage. |
I updated set_resolved_url to take a dict here: 05da9dc. The end_of_directory stuff still needs to be added, however. I'll use the applicable part of your PR. |
the common _listitemify() code is good. |
@ulion this can be closed now right? I think of the code/ideas from this PR have been incorporated? |
Ah, just noticed I have to add the _end_of_directory stuff to set_resolved_url. But then I believe everything is merged from this PR... |
enhanced set_resolved_url() function, can set mimetype, can set succeeded=False.
prevent auto-calling plugin.finish() by set flag, which should not be called when setResolvedUrl get called.
This should be what #54 wanted