Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleaned up regex function by introducing constants for patterns #143

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

cleaned up regex function by introducing constants for patterns #143

wants to merge 20 commits into from

Commits on Jul 26, 2020

  1. Speed up default clean function 

    speeded up the default function, by writing it in just one and let it operate on strings


Co-authored-by: Henri Froese <hf2000510@gmail.com>
    @henrifroese
    Maximilian Krahn and henrifroese committed Jul 26, 2020
    Configuration menu
    Copy the full SHA
    3ab14fd View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2020

  1. Regex pattern to constancs 

    removed the regex pattern from the functions and placed them in an constant above



Co-authored-by: Henri Froese <hf2000510@gmail.com>
    @mk2510 @henrifroese
    mk2510 and henrifroese committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    e0f02c5 View commit details
    Browse the repository at this point in the history

  2. changed clean function docstring 

    changed Docstring



Co-authored-by: Henri Froese <hf2000510@gmail.com>
    @mk2510 @henrifroese
    mk2510 and henrifroese committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    2ea3caf View commit details
    Browse the repository at this point in the history

  3. removed default pipeline for cleaning

    @mk2510
    mk2510 committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    697a229 View commit details
    Browse the repository at this point in the history

  4. added unittest for the clean function

    @mk2510
    mk2510 committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    4bb9860 View commit details
    Browse the repository at this point in the history

  5. format file

    @mk2510
    mk2510 committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    57c37c1 View commit details
    Browse the repository at this point in the history

  6. added unit test for clean function

    @mk2510
    mk2510 committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    db4934e View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2020

  1. updated naming schema

    @mk2510
    mk2510 committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    5887485 View commit details
    Browse the repository at this point in the history

  2. improved comment on helper function _get_pattern_for_tokenasiton()

    @mk2510
    mk2510 committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    addc23b View commit details
    Browse the repository at this point in the history

  3. fixed spelling mistake

    @mk2510
    mk2510 committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    84652ee View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into speed_up_preproce… 

    …ssing
    @mk2510
    mk2510 committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    3e7056b View commit details
    Browse the repository at this point in the history

  5. fixed some merge conflicts

    @mk2510
    mk2510 committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    16b775f View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2020

  1. Merge remote-tracking branch 'upstream/master' into speed_up_preproce… 

    …ssing
    @mk2510
    mk2510 committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    0b41020 View commit details
    Browse the repository at this point in the history

  2. rm optimised clean

    @mk2510
    mk2510 committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    af66252 View commit details
    Browse the repository at this point in the history

  3. inserted old clean 

    inserted the old cleaning pipeline



Co-authored-by: Henri Froese <hf2000510@gmail.com>
    @mk2510 @henrifroese
    mk2510 and henrifroese committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    7ab3a38 View commit details
    Browse the repository at this point in the history

  4. removed clean tests

    @mk2510
    mk2510 committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    a8fa33c View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2020

  1. changed the reviewed files

    @mk2510
    mk2510 committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    ebf6e49 View commit details
    Browse the repository at this point in the history

  2. fixed docstring length

    @mk2510
    mk2510 committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    c396231 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master_upstream' into constant_regex_pattern

    @mk2510
    mk2510 committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    fb4949d View commit details
    Browse the repository at this point in the history

  4. fixed formatting

    @mk2510
    mk2510 committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    244aca2 View commit details
    Browse the repository at this point in the history