Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/predict import error #9

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Bugfix/predict import error #9

merged 3 commits into from
Oct 16, 2023

Conversation

idoubi
Copy link
Contributor

@idoubi idoubi commented Oct 16, 2023

No description provided.

@idoubi
Copy link
Contributor Author

idoubi commented Oct 16, 2023

There is a bug when use OPENAI as llmEngine, import predictWithHuggingFace at top of the file will occur error when not set predictWithHuggingFace key.

image

I fixed this bug with async import in condition block.

One more thing, I changed the README file with the same params used in predict file.

jbilcke-hf
jbilcke-hf approved these changes Oct 16, 2023
View reviewed changes
Copy link
Owner

@jbilcke-hf jbilcke-hf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not loading what we don't use seems better indeed

@jbilcke-hf jbilcke-hf merged commit 938a431 into jbilcke-hf:main Oct 16, 2023
@jbilcke-hf
Copy link
Owner

Thank you for this pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbilcke-hf jbilcke-hf jbilcke-hf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@idoubi @jbilcke-hf