Force-include the specified paths in 'create' #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that if a PATH is specified directly in ``attic create`` is going to be included in the archive irregardless of the --exclude rules. We achieve this by building an intermediate exclusion list, and checking each exclusion pattern directly against the specified path. If the pattern matches, it's removed. This allows to have general exclusion rules while still including wanted subtrees in the archive. With the following file list: root/file1 root/unwanted/subtree1/file2 root/unwanted/subtree2/file3 The command: attic create archive::name --exclude root/unwanted root root/unwanted/subtree2 Will correctly archive: root/file1 root/unwanted/subtree2/file3. This reduces (removes?) the need of an additional --include flag, since it reduces the include/exclude logic to the most specific pattern directly specified on the command line.
|
+1. This would be an excellent feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that if a PATH is specified directly in
attic createis going to beincluded in the archive irregardless of the --exclude rules.
We achieve this by building an intermediate exclusion list, and checking each
exclusion pattern directly against the specified path. If the pattern matches,
it's removed.
This allows to have general exclusion rules while still including wanted
subtrees in the archive. With the following file list:
root/file1
root/unwanted/subtree1/file2
root/unwanted/subtree2/file3
The command:
attic create archive::name --exclude root/unwanted root root/unwanted/subtree2
Will correctly archive:
root/file1
root/unwanted/subtree2/file3.
This reduces (removes?) the need of an additional --include flag (as suggested in #104), since it
reduces the include/exclude logic to the most specific pattern directly
specified on the command line.