Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dealing with attic issues #5

Closed
maltefiala opened this issue May 14, 2015 · 63 comments
Closed

Dealing with attic issues #5

maltefiala opened this issue May 14, 2015 · 63 comments
Labels

Comments

@maltefiala
Copy link

@maltefiala maltefiala commented May 14, 2015

Here is a list of all open issues in attic, acquired with this dirty python script . I suggest we go through all of them and tick them when fixed.

Done / tracked here / invalid / out-of-scope:

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented May 14, 2015

I ticked all the stuff that's currently in borg master branch. There is some more stuff already fixed/improved that is not merged into there yet.

I am also ticking the items now that I think should be closed (because duplicate, irrelevant, stale, not enough infos, ...).

I'm also ticking the stuff that has own issues in the borg issue tracker.

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Jun 1, 2015

about jborg/attic#252 (fadvise DONTNEED): it is merged (and AFAICS using fadvise DONTNEED had positive effects).

https://github.com/borgbackup/borg/blob/master/borg/_chunker.c#L160

People seem to disagree whether that is beneficial or not.
I'll reconsider as soon as facts or at least good reasoning is available that indicates using it is wrong.

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Sep 5, 2015

about pull mode: it is ticked because we have an issue (which is a bit more general) in our issue tracker: #36

@anarcat
Copy link
Contributor

@anarcat anarcat commented Oct 5, 2015

it would have been nice to clarify which tickets are resolved, in the issue tracker or ignored instead of just ticking them off here... now we don't clearly know what's what...

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Oct 5, 2015

@anarcat I see your point, but I also don't want to make it even more work.

I mainly see the unchecked attic issues as stuff that has still to be looked at (and maybe dealt with), so that one does not have to go through all the issues there again and again. Of course we also need to deal with the issues in borg issue tracker.

What's really fixed can be seen more easily in CHANGES.rst.

@anarcat
Copy link
Contributor

@anarcat anarcat commented Oct 5, 2015

yeah ok, just trying to fix #224 here :)

@anarcat
Copy link
Contributor

@anarcat anarcat commented Oct 5, 2015

jborg/attic#99 implemented through #248

@anarcat
Copy link
Contributor

@anarcat anarcat commented Oct 5, 2015

jborg/attic#181 implemented through #247

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Oct 8, 2015

After doing a large volume test myself (see #216) and not finding issues, I'll check these ones as "can't reproduce" now:

jborg/attic#264
jborg/attic#176
jborg/attic#166

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Oct 17, 2015

Note: I put a checkmark in that (native) "windows support" attic issue. Not because we have native windows support (only cygwin), but because the related changesets there are rather messed up.

@anarcat
Copy link
Contributor

@anarcat anarcat commented Oct 20, 2015

jborg/attic#18 has been reopened in #315

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Dec 13, 2015

jborg/attic#70 is 404 (huh? how can that happen?)

but as we recently improved FUSE performance, I've just checked it as solved.

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Jan 12, 2016

i checked jborg/attic#367 in the list as we track this in #225.

@pacman88
Copy link

@pacman88 pacman88 commented Jan 25, 2016

Hi
In the list there is a point named "Pull mode" which is ticked. That is great since it is exactly what I need (schedule and manage backups from one central server). Unfortunately I can't find any hint in the docs how to make backups in pull mode.

so does that mean it is fixed/implemented but I am missing the docs or is it ticked by mistake?
(I would love to see pull mode implemented)

@anarcat
Copy link
Contributor

@anarcat anarcat commented Jan 25, 2016

@pacman88
Copy link

@pacman88 pacman88 commented Jan 25, 2016

@anarcat: thx - and sorry for just skimming over the thread

@ghost
Copy link

@ghost ghost commented Jan 26, 2016

Hi,

I'm unable to run borg create as I'm running into #317 (something related to NFS). Would you like me to open a separate issue in this repo?

info:

Platform: OpenBSD orchid.home 5.9 GENERIC.MP#1854 amd64 amd64
Borg: 0.30.0 Python: CPython 3.4.4
@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Jan 27, 2016

@Pyrohh it's unclear what your issue is. sure open a new ticket and provide enough information so we can reproduce.

@ghost
Copy link

@ghost ghost commented Jan 27, 2016

@ThomasWaldmann I'll do that, and I meant to link to jborg/attic#317, not #317 in this repo.

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Jan 27, 2016

@Pyrohh ah :) but i doubt it is same issue as that one as we do not use fcntl locking any more.

@ghost
Copy link

@ghost ghost commented Jan 27, 2016

False alarm, everything works after a reinstall... must have been the boogie man. Anyway, this is such a nice piece of software, thanks for working on it :D

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Feb 14, 2016

jborg/attic#103 checked, we have it now in ticket #661.

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Jul 22, 2016

checked attic 100, quite old and no response there.

@JensRantil
Copy link
Contributor

@JensRantil JensRantil commented Aug 1, 2016

FYI, just noticed jborg/attic#219 is closed.

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Aug 1, 2016

@JensRantil yes, but in borg, we'll do aes-gcm, likely in borg 1.2.

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Aug 11, 2016

attic 120 is borg #1462.

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Aug 15, 2016

checked attic 227 - in PR #1371 rpc api for exclusive flag was added, so remote and local repos are now more similar in how they lock. also, the deadlock was fixed.

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Aug 15, 2016

checked attic 383 - can be solved with borg with-lock ...

checked attic 384, out-of-scope / too special.

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Aug 15, 2016

attic 211 and 219 checked, tracked here by #1044 and #45.

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Aug 20, 2016

attic 131 checked. It is a rather old ticket, the tracebacks do not contain enough information.

Also, this issue is likely related to repository locking which is very different in borg (mkdir-based and since 1.0.7 immediately-exclusive) than in attic (posix locks, lock upgrades).

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Sep 5, 2016

Checked attic 387 - borg works on cygwin and there is an ongoing windows port in branch "windows".

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Oct 8, 2016

Checked attic 145, is locally tracked in #1695 now.

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Oct 21, 2016

attic 276 is now tracked locally in #1751.

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Dec 2, 2016

attic 195 is now tracked locally in #1783.

@enkore
Copy link
Contributor

@enkore enkore commented Dec 2, 2016

attic 345 has many local equivalents, including #1044 #672 #747 #45 and so on

@enkore
Copy link
Contributor

@enkore enkore commented Dec 2, 2016

attic 292 is solved since 1.0.8 (#1524).

from tw: attic 292 is about using different repo urls, borg #1524 is about saving the answer in any case, not just when doing write ops.

@enkore
Copy link
Contributor

@enkore enkore commented Dec 2, 2016

attic 210 is implemented with Manifest.config and borg_security_dir. Maybe create a internals doc ticket there?

from tw: yes that would be good, also for the changelog.

@enkore
Copy link
Contributor

@enkore enkore commented Dec 2, 2016

attic 207 is long implemented in Borg :) The crypto stuff has it's own tickets (see above).

from tw: some is implemented, some will (hopefully) come with 1.2. but yes, we can check it as we have local tickets.

@enkore
Copy link
Contributor

@enkore enkore commented Dec 2, 2016

attic 182: fuse archives are cached via a tempfile in the page cache. Resolved?

from tw: no, attic 182 is about a search index to optimize access to the right chunks.

@enkore
Copy link
Contributor

@enkore enkore commented Dec 2, 2016

attic 117 resolved in attic (also: fuse versions view, fuse repository mount, borg diff).

from tw: you mean "resolved in borg"? yes, fuse versions help, although it is not a general "file search" functionality. it only helps if you know the precise path.

@enkore
Copy link
Contributor

@enkore enkore commented Dec 2, 2016

attic 110: better locking is now done, otherwise it's covered by #768 and the like

from tw: ok, similar enough.

@enkore
Copy link
Contributor

@enkore enkore commented Dec 2, 2016

attic 104 is tracked locally in #1406

from tw: ok

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Jan 21, 2017

attic 393 is handled by borg #2092.

@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Feb 2, 2017

attic 395 checked - borg can be built with openssl 1.1.

@vjon
Copy link

@vjon vjon commented Apr 13, 2017

attic 386: I've opened #2415 to discuss this issue in the general case.

rupertdev pushed a commit to rupertdev/borg that referenced this issue Nov 24, 2017
remove remains of old website, redirect to RTD
@ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Feb 22, 2019

I'm closing this now. If we are missing something important here in the borg issue tracker, please file an issue here (after checking we do not already have one for it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants
You can’t perform that action at this time.