Change properties used to define image streams

[goldmann]

https://issues.jboss.org/browse/CLOUD-2732

This will make it easier to run on CI by specifying the image to test like this -Dimage=registry.corp/jboss-eap-7/eap71-openshift:dev.

[luck3y]

Thanks Marek, LGTM!

[bstansberry]

@goldmann @luck3y how are we tracking that these kinds of things are being done on all relevant dev branches (7.1, cd, soon-to-be-7.2)?

For 7.2, at least until close to GA release I plan to check changes to CD and bring any over that are needed. IOW that's only an issue for Ken and I. But we need tracking to ensure 7.1 stuff relevant to CD isn't dropped.

[luck3y]

@bstansberry I think thats a valid point, and usually I have jira issue for everything. For this one, since its moving the existing tests into the eap71 image we skipped it. I'll make an issue for it, and ensure we don't omit others.

My plan was to get these passing on eap71, then cherry pick to eap-cd-dev and make further modifications / add more tests.

[luck3y]

Jira added, I'll add the other PR that moved the tests to that too.

[luck3y]

So, the other bit of this was I was going to make a ticket for the CD part. We could make a 7.2 ticket too ... but that seems excessive for every change?

I can make the ticket apply to 7.2 / CD and open a 7.2 PR either against your working branch or the repo, if its there when we do this maybe? WDYT?

[luck3y]

https://issues.jboss.org/browse/CLOUD-2733

[bstansberry]

@luck3y Sending PRs for 7.2 to my working branch or eap72-dev once it's in the main repo is fine. If we have a change in CD and we know it applies to 7.2 it's good to be proactive and get it in. Before we hit the code freeze for the 7.2 GA images I definitely intend to audit the history of eap-cd-dev though to make sure we didn't drop things. I'd be much happier if we didn't need to audit 7.1 as well though.