Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHPAM-3331] Operator for AMQ Streams (Kafka) integration #446

Merged
merged 1 commit into from Mar 26, 2021
Merged

[RHPAM-3331] Operator for AMQ Streams (Kafka) integration #446

merged 1 commit into from Mar 26, 2021

Conversation

desmax74
Copy link
Contributor

@desmax74 desmax74 commented Mar 22, 2021 •
edited

See: https://issues.redhat.com/browse/RHPAM-3331
Signed-off-by: desmax74 mdessi@redhat.com

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [KIECLOUD-XYZ] Subject, [RHDM-XYZ] Subject or [RHPAM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

@kie-ci-bot kie-ci-bot bot added the needs review 🔍 Pull Request that needs reviewers label Mar 22, 2021
@desmax74 desmax74 marked this pull request as draft March 22, 2021 18:15
@desmax74 desmax74 marked this pull request as ready for review March 23, 2021 06:24
@desmax74 desmax74 force-pushed the rhpam-3331b branch 2 times, most recently from 716cd09 to 79c4658 Compare March 23, 2021 06:32
@desmax74 desmax74 added the 7.12.x ⇨ 7.12.0 7.12.x branch work for version 7.12.0 release (CR build/test) label Mar 23, 2021
@desmax74
Copy link
Contributor Author

desmax74 commented Mar 23, 2021 •
edited

@spolti @jakubschwan

This was referenced Mar 23, 2021
Merged
Merged
spolti
spolti requested changes Mar 24, 2021
View reviewed changes
Copy link
Member

@spolti spolti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, just minor changes needed now.
also, please take a look at the tests, seems that something is failing.

tests/features/common/kie-kieserver-common.feature Outdated Show resolved Hide resolved
jboss-kie-kieserver/tests/bats/jboss-kie-kieserver.bats Show resolved Hide resolved
@spolti spolti mentioned this pull request Mar 24, 2021
Merged
spolti
spolti previously approved these changes Mar 26, 2021
View reviewed changes
@spolti
Copy link
Member

spolti commented Mar 26, 2021

@desmax74 can you please rebase?

@desmax74
Kafka Extension
3a4bf96 
Signed-off-by: desmax74 <mdessi@redhat.com>
@desmax74
Copy link
Contributor Author

@spolti rebased

@desmax74 desmax74 removed the needs review 🔍 Pull Request that needs reviewers label Mar 26, 2021
@spolti spolti added the ready 🚀 work completed and ready to be merged label Mar 26, 2021
@desmax74 desmax74 merged commit f3c114a into jboss-container-images:master Mar 26, 2021
@desmax74 desmax74 deleted the rhpam-3331b branch January 28, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spolti spolti spolti approved these changes

@jakubschwan jakubschwan Awaiting requested review from jakubschwan

@Kaitou786 Kaitou786 Awaiting requested review from Kaitou786

@msmagnanijr msmagnanijr Awaiting requested review from msmagnanijr

Assignees
No one assigned
Labels
7.12.x ⇨ 7.12.0 7.12.x branch work for version 7.12.0 release (CR build/test) ready 🚀 work completed and ready to be merged
Milestone
No milestone
2 participants
@desmax74 @spolti