Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHBA-724] Added rhpam70-trial-ephemeral template #26

Merged

Conversation

bmozaffa
Copy link
Contributor

@bmozaffa bmozaffa commented Apr 6, 2018

https://issues.jboss.org/browse/RHBA-724

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [CLOUD-XYA] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

@errantepiphany errantepiphany self-requested a review April 6, 2018 19:16
Copy link
Collaborator

@errantepiphany errantepiphany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the introduction of the DEFAULT_PASSWORD. That makes this a lot easier to use. My only requested change would be to squash your 2 commits into 1. Thanks!

@bmozaffa
Copy link
Contributor Author

bmozaffa commented Apr 6, 2018

@errantepiphany Thanks David, my only hesitation was that I wanted the rename of rhpam70-kieserver.yaml to be in the history, versus it appearing as a delete followed by a new template creation. Let me know what you prefer.

…l.yaml, edited to connect business central and kie server with ephemeral storage for both

Signed-off-by: Babak Mozaffari <bmozaffa@redhat.com>
@errantepiphany errantepiphany merged commit fa941c6 into jboss-container-images:rhpam70-dev Apr 6, 2018
@@ -159,17 +97,11 @@ parameters:
- displayName: Maven repository URL
description: Fully qualified URL to a Maven repository.
name: MAVEN_REPO_URL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmozaffa Does it have sense to allow definition of Maven repo URL in this template? AFAIK the Kie server should use just repo from Workbench which is defined by MAVEN_REPO_SERVICE in Deployment config.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sutaakar No, I think you're right and it doesn't make sense, thanks for spotting the error. However, I'm trying to figure out how to deal with a dependency that's in an external Maven. Might be better to wait and figure that out first, as it would affect how this should be addressed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sutaakar This is now addressed by #38, though it might yet be refactored further after other PRs merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants