Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[EAP6-69] Modify the quickstart to make use of the new API to achieve this capability. #868

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

darranl commented Mar 6, 2014

No description provided.

@rafabene rafabene commented on an outdated diff Mar 10, 2014

ejb-security-interceptors/pom.xml
@@ -46,7 +46,7 @@
<version.jboss.maven.plugin>7.4.Final</version.jboss.maven.plugin>
- <version.jboss.as>7.2.1.Final-redhat-10</version.jboss.as>
+ <version.jboss.as>7.4.0.Final-redhat-SNAPSHOT</version.jboss.as>
@rafabene

rafabene Mar 10, 2014

Contributor

Shouldn't we release a -build version on jboss-developer.github.io/temp-maven-repo/ ?

Contributor

sgilda commented Mar 10, 2014

@rafabene is right. This is an API change, however. This change will break this for JBoss EAP 6.2. You need JBoss EAP 6.3 for this one.

@darranl , I noticed a few things:

  • These changes only work against EAP 6.3, correct?
  • Should the README be updated to talk about the new API and also to note that it only works against JBoss EAP 6.3?

I am having difficulty getting this to compile.
I believe the new module should be added to the http://jboss-developer.github.io/temp-maven-repo/ Maven repository
I had to changed the following property:

    <!--   <version.jboss.as>7.4.0.Final-redhat-SNAPSHOT</version.jboss.as> -->
    <version.jboss.as>7.4.0.Final-redhat-2</version.jboss.as>

Even with these changes, I get the following errors when I try to build the quickstart:

    [ERROR] The build could not read 1 project -> [Help 1]
    [ERROR]   
    [ERROR]   The project org.jboss.quickstarts.eap:jboss-ejb-security-interceptors:6.2.0-redhat-SNAPSHOT (/home/sgilda/GitRepos/jboss-eap-quickstarts/ejb-security-interceptors/pom.xml) has 2 errors
    [ERROR]     'dependencies.dependency.version' for org.jboss.as:jboss-as-security-api:jar is missing. @ line 90, column 21
    [ERROR]     'dependencies.dependency.version' for org.wildfly:wildfly-core-security-api:jar is missing. @ line 94, column 21

I also noticed the following in the POM file, which does not sound correct:

    <dependency>
        <groupId>org.wildfly</groupId>
        <artifactId>wildfly-core-security-api</artifactId>
    </dependency>
Contributor

sgilda commented Mar 13, 2014

Now I am getting this error on the build:

[ERROR] The project org.jboss.quickstarts.eap:jboss-ejb-security-interceptors:6.2.0-redhat-SNAPSHOT (/home/sgilda/GitRepos/jboss-eap-quickstarts/ejb-security-interceptors/pom.xml) has 9 errors
[ERROR] Non-resolvable import POM: Could not find artifact org.jboss.as:jboss-as-ejb-client-bom:pom:7.4.0.build-1 in jboss-developer-repository (http://jboss-developer.github.io/temp-maven-repo/) @ line 78, column 25 -> [Help 2]
[ERROR] 'dependencies.dependency.version' for org.jboss.as:jboss-as-security-api:jar is missing. @ line 90, column 21
[ERROR] 'dependencies.dependency.version' for org.picketbox:picketbox:jar is missing. @ line 104, column 21
[ERROR] 'dependencies.dependency.version' for org.wildfly:wildfly-core-security-api:jar is missing. @ line 109, column 21
[ERROR] 'dependencies.dependency.version' for org.jboss.ejb3:jboss-ejb3-ext-api:jar is missing. @ line 146, column 21
[ERROR] 'dependencies.dependency.version' for org.jboss:jboss-ejb-client:jar is missing. @ line 153, column 21
[ERROR] 'dependencies.dependency.version' for org.jboss.xnio:xnio-api:jar is missing. @ line 159, column 21
[ERROR] 'dependencies.dependency.version' for org.jboss.xnio:xnio-nio:jar is missing. @ line 165, column 21
[ERROR] 'dependencies.dependency.version' for org.jboss.marshalling:jboss-marshalling-river:jar is missing. @ line 172, column 21
[ERROR]

@sgilda sgilda commented on the diff Mar 13, 2014

ejb-security-interceptors/pom.xml
+ <groupId>org.jboss.as</groupId>
+ <artifactId>jboss-as-build-config</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.jboss.as</groupId>
+ <artifactId>jboss-as-security</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.picketbox</groupId>
+ <artifactId>picketbox</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>org.wildfly</groupId>
@sgilda

sgilda Mar 13, 2014

Contributor

Do we need wildfly dependencies with EAP 6.3?

@darranl

darranl Mar 13, 2014

Contributor

Yes this is the name of the module containing the new API

@darranl darranl [EAP6-69] Specify the exact version just for the new API artefacts, l…
…eave the original dependencies on the old version.
44a007b
Contributor

sgilda commented Mar 13, 2014

@darranl : Got further this time, but got this error:

[ERROR] Failed to execute goal on project jboss-ejb-security-interceptors: Could not resolve dependencies for project org.jboss.quickstarts.eap:jboss-ejb-security-interceptors:jar:6.2.0-redhat-SNAPSHOT: Failed to collect dependencies for [org.jboss.as:jboss-as-security-api:jar:7.4.0.build-1 (compile), org.picketbox:picketbox:jar:4.0.17.SP2-redhat-2 (compile), org.wildfly:wildfly-core-security-api:jar:7.4.0.build-1 (compile), javax.enterprise:cdi-api:jar:1.0-SP4-redhat-2 (compile), org.jboss.spec.javax.annotation:jboss-annotations-api_1.1_spec:jar:1.0.1.Final-redhat-2 (compile), org.jboss.spec.javax.servlet:jboss-servlet-api_3.0_spec:jar:1.0.2.Final-redhat-1 (compile), org.jboss.spec.javax.ejb:jboss-ejb-api_3.1_spec:jar:1.0.2.Final-redhat-2 (compile), org.jboss.ejb3:jboss-ejb3-ext-api:jar:2.0.0-redhat-2 (compile), org.jboss:jboss-ejb-client:jar:1.0.23.Final-redhat-1 (compile), org.jboss.xnio:xnio-api:jar:3.0.7.GA-redhat-1 (runtime), org.jboss.xnio:xnio-nio:jar:3.0.7.GA-redhat-1 (runtime), org.jboss.marshalling:jboss-marshalling-river:jar:1.3.18.GA-redhat-1 (runtime), org.jboss.spec.javax.transaction:jboss-transaction-api_1.1_spec:jar:1.0.1.Final-redhat-2 (runtime)]: Failed to read artifact descriptor for org.jboss.as:jboss-as-security-api:jar:7.4.0.build-1: Could not find artifact org.jboss.as:jboss-as-security-parent:pom:7.4.0.build-1 in jboss-developer-repository (http://jboss-developer.github.io/temp-maven-repo/) -> [Help 1]

Contributor

darranl commented Mar 13, 2014

I will have another look later.

@darranl darranl [EAP6-69] Add a dependency on JBoss SASL, this was previously being i…
…mported as a tansitive dependency however if we add it like this we can ensure it is a runtime only dependency.
64602a4
Contributor

sgilda commented Mar 14, 2014

This was merged.

@sgilda sgilda closed this Mar 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment