-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EAP6-69] Modify the quickstart to make use of the new API to achieve this capability. #868
Conversation
@@ -46,7 +46,7 @@ | |||
|
|||
<version.jboss.maven.plugin>7.4.Final</version.jboss.maven.plugin> | |||
|
|||
<version.jboss.as>7.2.1.Final-redhat-10</version.jboss.as> | |||
<version.jboss.as>7.4.0.Final-redhat-SNAPSHOT</version.jboss.as> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we release a -build version on jboss-developer.github.io/temp-maven-repo/ ?
@rafabene is right. This is an API change, however. This change will break this for JBoss EAP 6.2. You need JBoss EAP 6.3 for this one. @darranl , I noticed a few things:
I am having difficulty getting this to compile.
Even with these changes, I get the following errors when I try to build the quickstart:
I also noticed the following in the POM file, which does not sound correct:
|
Now I am getting this error on the build: [ERROR] The project org.jboss.quickstarts.eap:jboss-ejb-security-interceptors:6.2.0-redhat-SNAPSHOT (/home/sgilda/GitRepos/jboss-eap-quickstarts/ejb-security-interceptors/pom.xml) has 9 errors |
</dependency> | ||
|
||
<dependency> | ||
<groupId>org.wildfly</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need wildfly dependencies with EAP 6.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is the name of the module containing the new API
…eave the original dependencies on the old version.
@darranl : Got further this time, but got this error: [ERROR] Failed to execute goal on project jboss-ejb-security-interceptors: Could not resolve dependencies for project org.jboss.quickstarts.eap:jboss-ejb-security-interceptors:jar:6.2.0-redhat-SNAPSHOT: Failed to collect dependencies for [org.jboss.as:jboss-as-security-api:jar:7.4.0.build-1 (compile), org.picketbox:picketbox:jar:4.0.17.SP2-redhat-2 (compile), org.wildfly:wildfly-core-security-api:jar:7.4.0.build-1 (compile), javax.enterprise:cdi-api:jar:1.0-SP4-redhat-2 (compile), org.jboss.spec.javax.annotation:jboss-annotations-api_1.1_spec:jar:1.0.1.Final-redhat-2 (compile), org.jboss.spec.javax.servlet:jboss-servlet-api_3.0_spec:jar:1.0.2.Final-redhat-1 (compile), org.jboss.spec.javax.ejb:jboss-ejb-api_3.1_spec:jar:1.0.2.Final-redhat-2 (compile), org.jboss.ejb3:jboss-ejb3-ext-api:jar:2.0.0-redhat-2 (compile), org.jboss:jboss-ejb-client:jar:1.0.23.Final-redhat-1 (compile), org.jboss.xnio:xnio-api:jar:3.0.7.GA-redhat-1 (runtime), org.jboss.xnio:xnio-nio:jar:3.0.7.GA-redhat-1 (runtime), org.jboss.marshalling:jboss-marshalling-river:jar:1.3.18.GA-redhat-1 (runtime), org.jboss.spec.javax.transaction:jboss-transaction-api_1.1_spec:jar:1.0.1.Final-redhat-2 (runtime)]: Failed to read artifact descriptor for org.jboss.as:jboss-as-security-api:jar:7.4.0.build-1: Could not find artifact org.jboss.as:jboss-as-security-parent:pom:7.4.0.build-1 in jboss-developer-repository (http://jboss-developer.github.io/temp-maven-repo/) -> [Help 1] |
I will have another look later. |
…mported as a tansitive dependency however if we add it like this we can ensure it is a runtime only dependency.
This was merged. |
No description provided.