Add micrometer tests #289
Merged
Add micrometer tests #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 14, 2024 15:51
…adding deployment resources
fabiobrz
requested review from
jbliznak and
marekkopecky
and removed request for
jbliznak
…and multiple WAR ones don't fit and the DOcker one is tested within the remote Arquillian container (WildFly/EAP/XP) which makes it tricky to implement as a bootable jar based one
micrometer/src/test/java/org/jboss/eap/qe/micrometer/container/JaegerContainer.java
Outdated
Show resolved
Hide resolved
|
I'm not much happy about the javadoc (missing/poor) of classes copy-pasted from wildfly. But my understanding is that this is temporary solution, so I'm ok with it now. |
micrometer/src/test/java/org/jboss/eap/qe/micrometer/multiple/BaseMultipleTestCase.java
Show resolved
Hide resolved
|
I added just a few minor comments, otherwise LGTM, thank you! |
Should be fixed now, thanks @marekkopecky ! |
|
Thank you for the changes, all threads are resolved, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting tests in wildfly/wildfly#17898 in order to be able and test Micrometer integration in JBoss EAP XP 5.
Please make sure your PR meets the following requirements:
LinkReference to the passing job is provided