[WFLY-19351] Add Micrometer test to verify that applications with shared metrics names are not merged when exported #17898
+616
−209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstansberry
requested changes
Jun 7, 2024
There was a problem hiding this comment.
@jasondlee I made a bunch of code style comments but the substantive change LGTM.
...ile/src/test/java/org/wildfly/test/integration/observability/container/PrometheusMetric.java
Show resolved
Hide resolved
...org/wildfly/test/integration/observability/micrometer/MicrometerOtelIntegrationTestCase.java
Show resolved
Hide resolved
...ava/org/wildfly/test/integration/observability/micrometer/multiple/BaseMultipleTestCase.java
Show resolved
Hide resolved
...ava/org/wildfly/test/integration/observability/micrometer/multiple/BaseMultipleTestCase.java
Show resolved
Hide resolved
...ava/org/wildfly/test/integration/observability/micrometer/multiple/BaseMultipleTestCase.java
Outdated
Show resolved
Hide resolved
...java/org/wildfly/test/integration/observability/micrometer/multiple/MultipleWarTestCase.java
Show resolved
Hide resolved
...java/org/wildfly/test/integration/observability/micrometer/multiple/MultipleWarTestCase.java
Show resolved
Hide resolved
...test/integration/observability/micrometer/multiple/application/DuplicateMetricResource1.java
Show resolved
Hide resolved
...test/integration/observability/micrometer/multiple/application/DuplicateMetricResource2.java
Show resolved
Hide resolved
.../wildfly/test/integration/observability/micrometer/multiple/application/TestApplication.java
Show resolved
Hide resolved
Thanks. I'll get these updated as soon as I can. |
|
@bstansberry All changes should be address 'cept for the import order. Those have been updated, but I'll wait to resolve those until I can confirm I have the right order. :) |
jasondlee
force-pushed
the
WFLY-19351
branch
2 times, most recently
from
bbec34b
to
c939c38
Compare
bstansberry
previously approved these changes
Jun 13, 2024
6 tasks
bstansberry
dismissed
their stale review
@jasondlee I'm withdrawing my approval because the tests are failing.
@bstansberry You're so picky. :) I've been reworking the tests so they should be more stable. Will be pushing an update "soon" |
jasondlee
force-pushed
the
WFLY-19351
branch
3 times, most recently
from
3b7ea25
to
496bc27
Compare
…red metrics names are not merged when exported Add test with multiple war deployments Add test with ear with multiple war subdeployments Rework how Prometheus metrics are retrieved and handled Add test to verify that metrics with identical names are exported separately Add a TestEnricher to manage lifecycle and injection of the Otel container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFLY-19351
Add test with multiple war deployments
Add test with ear with multiple war subdeployments
Rework how Prometheus metrics are retrieved and handled
Add test to verify that metrics with identical names are exported separately
More information about the wildfly-bot[bot]