Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(knative): apply the knative sinklabel in ns regardless of SINK_BINDING_SELECTION_MODE #115

Merged
merged 1 commit into from
Aug 23, 2022
Merged

fix(knative): apply the knative sinklabel in ns regardless of SINK_BINDING_SELECTION_MODE #115

merged 1 commit into from
Aug 23, 2022

Conversation

claudio4j
Copy link

  • just apply the label in namespace where the integration is running
  • don't verify the SINK_BINDING_SELECTION_MODE in deploy/eventing-webhook in knative-eventing namespace

@claudio4j
fix(knative): apply the knative sinklabel in ns regardless of SINK_BI…
7354d84 
…NDING_SELECTION_MODE

* just apply the label in namespace where the integration is running
* don't verify the SINK_BINDING_SELECTION_MODE in
  deploy/eventing-webhook in knative-eventing namespace
christophd
christophd approved these changes Aug 23, 2022
View reviewed changes
Copy link

@christophd christophd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@claudio4j claudio4j merged commit d20d89d into jboss-fuse:release-1.8.x Aug 23, 2022
@claudio4j claudio4j deleted the prod-1.8x-fix_knative_label branch August 23, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophd christophd christophd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@claudio4j @christophd