Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checked declaring class internally whether or not it is Kotlin class … #276

Closed
wants to merge 1 commit into from

Conversation

serkan-ozal
Copy link

…while inserting after method body

@chibash
Copy link
Member

chibash commented Sep 23, 2019

Including isKotlinClass() in insertAfter() causes an extra overhead even when the class is a Java class. So I added isKotlin() to CtClass and leaved insertAfter() without a call to isKotlinClass(). I also added how to call isKotlin() when calling insertAfter() to the javadoc.
Note that not only the Kotlin compiler generates the bytecode we need to the redundant insertAfter() but also a Java compiler such as Eclipse's may do.

@chibash chibash closed this Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants