Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a module-info file #45

Merged
merged 1 commit into from Apr 22, 2022
Merged

Provide a module-info file #45

merged 1 commit into from Apr 22, 2022

Conversation

dmlloyd
Copy link
Member

@dmlloyd dmlloyd commented Apr 5, 2022

All of the logging backend dependencies are marked as optional (static).

@jamezp
Copy link
Member

jamezp commented Apr 5, 2022

Maybe the decompilation just isn't write, but this is what the module-info.class decompiles to:

module org.jboss.logging {
    requires org.jboss.logmanager;
    requires org.slf4j;
    requires log4j.api;
    requires org.apache.logging.log4j;

    exports org.jboss.logging;

    uses org.jboss.logging.LoggerProvider;
}

There is not static modifier.

@dmlloyd
Copy link
Member Author

dmlloyd commented Apr 5, 2022

What are you using for decompilation? javap gives this:

Compiled from "module-info.yml"
module org.jboss.logging@3.4.4.Final-SNAPSHOT {
  requires static org.jboss.logmanager;
  requires static org.slf4j;
  requires static log4j.api;
  requires static org.apache.logging.log4j;
  requires java.base;
  exports org.jboss.logging;
  uses org.jboss.logging.LoggerProvider;
}

@jamezp
Copy link
Member

jamezp commented Apr 6, 2022

Ah interesting. I was just using IDEA. It does look right with javap so I trust that for sure :)

@jponge
Copy link

jponge commented Apr 6, 2022

Note that you don't have to set a requires java.base

@jponge
Copy link

jponge commented Apr 6, 2022

@dmlloyd
Copy link
Member Author

dmlloyd commented Apr 6, 2022

java.base is always added automatically as a ACC_MANDATED dependency. It should only appear when using javap though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants