-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module-info
to most (not all) submodules
#155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
radcortez
approved these changes
Apr 6, 2022
@jponge will this work for you? |
Let me check 😃 |
Just tested locally, I can resolve Thanks @dmlloyd @radcortez |
See also jboss-logging/jboss-logging#45 |
This was referenced Apr 22, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
module-info
to every submodule which falls under one of these categories:module-info
The
module-info
descriptor is generated by mymodule-info
Maven plugin. This is because the operation of that plugin is very simple and predictable (to me), and it produces amodule-info.class
file directly without trying to pass an intermediatemodule-info.java
throughjavac
, which doesn't work well. Another reason is that the generatedmodule-info.class
has a complete package list and version, whichjavac
does not add (normally thejar
tool handles this but Maven doesn't use it).There are a few modules which depend on JBoss Logging or another dependency which does not yet have a
module-info
descriptor:expression
net
version
vertx-context
One temporary solution for the first three could be to throw on a dependency for
org.jboss.logging
and let it break until we get it sorted out in that project with a release.Another note: the surefire plugin has to be updated otherwise Java 8 testing breaks terribly with
module-info
. If #153 is merged, then surefire doesn't need to be upgraded since Java 8 testing would be removed.An exception is the
annotation
submodule, which is the instigating case for this PR; the dependency used forjavax.inject.Qualifier
does not contain amodule-info
nor does it contain an automatic module name. Since it's an annotation, it seems like we could get away without the dependency. We may want to introduce arequires static
for the official module coordinates of that artifact, if there are any.