Remove the explicit dependency on org.jboss.logmanager and add an exp… #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlloyd
approved these changes
Jun 28, 2023
| // Therefore, we check the modules are named, and if they are we add an explicit reads. | ||
| final Module module = LoggerProviders.class.getModule(); | ||
| if (module.isNamed() && jblLogManager.getModule().isNamed()) { | ||
| module.addReads(jblLogManager.getModule()); |
There was a problem hiding this comment.
I think you want to addReads even if jblLogManager is in the unnamed module.
There was a problem hiding this comment.
I had it that way at first, then questioned myself. I'll change it back :)
…licit opens to the module if it exists. Signed-off-by: James R. Perkins <jperkins@redhat.com>
jamezp
force-pushed
the
module-workaround
branch
from
1ae7725
to
4a59f75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…licit opens to the module if it exists.