Various MSC 1.2 fixes - first round #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-stop propagation, which may allow an inconsistency in counts" This reverts commit 3a88e07.
…t.failed() but not both.
…ser forgot to call StartContext lifecycle methods.
…risoned forever in STOP_REQUESTED state. This situation can happen in the following scenario: * Dependent controller moved from STARTING to START_FAILED state * Dependent controller is asked to retry() * On success dependent controller will move from START_FAILED to STARTING state The problem is during that transition the number of dependents is incremented for each dependency and these increments are never compensated.
…nsitions: * START_REQUESTED -> START_INITIATING * DOWN -> REMOVING
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various MSC1 fixes - first round