Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various MSC 1.2 fixes - first round #49

Merged
merged 9 commits into from
May 15, 2017
Merged

Various MSC 1.2 fixes - first round #49

merged 9 commits into from
May 15, 2017

Commits on May 15, 2017

  1. Revert "[MSC-155] Fix problem where lock is not held during dependent… 

    …-stop propagation, which may allow an inconsistency in counts"

This reverts commit 3a88e07.
    @ropalka
    ropalka committed May 15, 2017
    Configuration menu
    Copy the full SHA
    3407341 View commit details
    Browse the repository at this point in the history

  2. [MSC-160] User can call either StartContext.complete() or StartContex… 

    …t.failed() but not both.
    @ropalka
    ropalka committed May 15, 2017
    Configuration menu
    Copy the full SHA
    649aa60 View commit details
    Browse the repository at this point in the history

  3. [MSC-161] Removing profiling support - it's not needed anymore.

    @ropalka
    ropalka committed May 15, 2017
    Configuration menu
    Copy the full SHA
    c8baa22 View commit details
    Browse the repository at this point in the history

  4. [MSC-162] Decoupling StartContext/StopContext from ServiceControllerI… 

    …mpl lock
    @ropalka
    ropalka committed May 15, 2017
    Configuration menu
    Copy the full SHA
    3da36f2 View commit details
    Browse the repository at this point in the history

  5. [MSC-163] Refactoring - moving perform*Injetions() methods upwards

    @ropalka
    ropalka committed May 15, 2017
    Configuration menu
    Copy the full SHA
    646262c View commit details
    Browse the repository at this point in the history

  6. [MSC-163] Fixing broken 'out injections' - they worked only in case u… 

    …ser forgot to call StartContext lifecycle methods.
    @ropalka
    ropalka committed May 15, 2017
    Configuration menu
    Copy the full SHA
    af1b734 View commit details
    Browse the repository at this point in the history

  7. [MSC-164] Fixing bug which may cause dependency controllers to be imp… 

    …risoned forever in STOP_REQUESTED state.

This situation can happen in the following scenario:
 * Dependent controller moved from STARTING to START_FAILED state
 * Dependent controller is asked to retry()
 * On success dependent controller will move from START_FAILED to STARTING state

The problem is during that transition the number of
dependents is incremented for each dependency and these
increments are never compensated.
    @ropalka
    ropalka committed May 15, 2017
    Configuration menu
    Copy the full SHA
    e860654 View commit details
    Browse the repository at this point in the history

  8. [MSC-165] Eliminating REMOVING -> DOWN transition. It never worked.

    @ropalka
    ropalka committed May 15, 2017
    Configuration menu
    Copy the full SHA
    16bc8f5 View commit details
    Browse the repository at this point in the history

  9. [MSC-166] Adding missing Listener notifications for the following tra… 

    …nsitions:

 * START_REQUESTED -> START_INITIATING
 * DOWN -> REMOVING
    @ropalka
    ropalka committed May 15, 2017
    Configuration menu
    Copy the full SHA
    4b0a7bf View commit details
    Browse the repository at this point in the history