[CLOUD-940] Expose the MAVEN_MIRROR_URL variable for JDV #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jwendell did for this one, too - displayName now appears first. |
luksa
reviewed
Feb 22, 2017
| @@ -494,6 +501,10 @@ | |||
| { | |||
| "name": "VDB_DIRS", | |||
| "value": "${VDB_DIRS}" | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Indentation needs to be fixed here.
luksa
reviewed
Feb 22, 2017
datavirt/datavirt63-basic-s2i.json
Outdated
| }, | ||
| { | ||
| "displayName": "Maven mirror URL", | ||
| "description": "Maven mirror to use for s2i builds", |
There was a problem hiding this comment.
Maybe change s2i to uppercase.
If set, it will be used by s2i while building sources.
|
Done. |
|
Closing, replaced by #253 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If set, it will be used by s2i while building sources.