Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REM3-189] Change URI from host name to host address #20

Closed
wants to merge 1 commit into from
Closed

[REM3-189] Change URI from host name to host address #20

wants to merge 1 commit into from

Conversation

systemtrap
Copy link

@dmlloyd
Copy link
Member

dmlloyd commented Oct 2, 2014

We require that all contributions be made under the terms of the MIT License, http://www.opensource.org/licenses/mit-license.php. Do you agree to the these terms?

And also, it is very likely that this project will shortly be relicensed to the Apache license version 2.0. Do you agree to this change in license?

@dmlloyd
Copy link
Member

dmlloyd commented Nov 12, 2014

Rejecting this PR. If you look very closely, the code has already been changed from using getHostName() to getHostString(), the latter of which will never do a reverse lookup.

@dmlloyd dmlloyd closed this Nov 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants