Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes made w.r.t. JDK 9 #109

Closed
wants to merge 2 commits into from
Closed

Conversation

wolfc
Copy link
Contributor

@wolfc wolfc commented Mar 21, 2017

With or without these changes, compiling with JDK 9 currently does not work anyway.

The actual change also causes a regression as mentioned in https://issues.jboss.org/browse/JBEAP-9670.

@ctomc
Copy link
Contributor

ctomc commented Mar 21, 2017

how can this cause regression if there was no release with this changes done yet?

@ctomc
Copy link
Contributor

ctomc commented Mar 21, 2017

and just checked with JDK9 b160 it builds just fine, there are two xsd compare failures, but compile / build works just fine

@wolfc
Copy link
Contributor Author

wolfc commented Mar 23, 2017

https://issues.jboss.org/browse/JBMETA-399
Seems compiling on Ubuntu 16.04 is an issue.

  1. master branch is currently the maintenance branch for EAP 7.0. It can not go beyond Java 8 and everything must be acked.
  2. Compilation with JDK 9 EA 161 without the JDK 9 commits works fine. Since there is no issue reference to the original problem, I consider these changes related to a non-issue.

@wolfc
Copy link
Contributor Author

wolfc commented Mar 23, 2017

I figured out why the build is working on JDK 9: with -source 1.8 the modular system isn't enabled.

@wolfc
Copy link
Contributor Author

wolfc commented Mar 23, 2017

The actual regression is:

java.time.format.DateTimeParseException: Text '1990-01-01T00:00:00' could not be parsed at index 19

	at java.time.format.DateTimeFormatter.parseResolved0(DateTimeFormatter.java:1949)
	at java.time.format.DateTimeFormatter.parse(DateTimeFormatter.java:1851)
	at java.time.ZonedDateTime.parse(ZonedDateTime.java:597)
	at java.time.ZonedDateTime.parse(ZonedDateTime.java:582)
	at org.jboss.metadata.ejb.parser.spec.TimerMetaDataParser.parseDateTime(TimerMetaDataParser.java:130)

@wolfc
Copy link
Contributor Author

wolfc commented Apr 13, 2017

Superseded by #110

@wolfc wolfc closed this Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants