JBMETA-400: ensure using the new time API works correctly for ISO 8601 dates #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfc
commented
Mar 24, 2017
| @@ -28,7 +28,7 @@ | |||
| <parent> | |||
| <groupId>org.jboss</groupId> | |||
| <artifactId>jboss-parent</artifactId> | |||
| <version>21</version> | |||
| <version>11</version> | |||
There was a problem hiding this comment.
Using parent 19 (currently in use by EAP 7.0) in conjunction with JDK 9 gives Maven compatibility errors.
There was a problem hiding this comment.
please use version 22, it has important changes wrt to building on JDK9.
It is what all projects are moving to, WildFly master & upcoming EAP 7.1 uses that.
There was a problem hiding this comment.
That version is not available for EAP 7.0. For now I'm going to revert to 11 and revisit once we get to actually needing it. In other words, once we actually have a properly filed issue that outlines any Java 9 problems with the current build.
wolfc
added a commit
that referenced
this pull request
Mar 24, 2017
JBMETA-400: ensure using the new time API works correctly for ISO 8601 dates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/JBMETA-400
Ensures the fault as mentioned in https://issues.jboss.org/browse/JBEAP-9670 does not occur.