[JBEAP-24939] JDK 17 Support for XP 4 Helm Charts #60
Conversation
github-actions
bot
added
charts
documentation
charts/eap-xp4/README.md
Outdated
| | `build.s2i.featurePacks` | List of additional Galleon feature-packs identified by Maven coordinates (`<groupId>:<artifactId>:<version>`) | - | The value can be be either a `string` with a list of comma-separated Maven coordinate or an array where each item is the Maven coordinate of a feature pack - [EAP Documentation](https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_application_platform/7.4/html/getting_started_with_jboss_eap_for_openshift_container_platform/index) | | ||
| | `build.bootableJar.builderImage` | JDK Builder image for Bootable Jar | [registry.access.redhat.com/ubi8/openjdk-11:latest](https://catalog.redhat.com/software/containers/ubi8/openjdk-11/5dd6a4b45a13461646f677f4?gti-tabs=unauthenticated) | - | | ||
| | `build.bootableJar.builderImage` | JDK Builder image for Bootable Jar | [registry.access.redhat.com/ubi8/openjdk-11:latest](https://catalog.redhat.com/software/containers/ubi8/openjdk-11/5dd6a4b45a13461646f677f4?gti-tabs=unauthenticated) | - | |
There was a problem hiding this comment.
It seems there's a formatting issue on your IDE that's adding spaces after end on line?
There was a problem hiding this comment.
Yes, I am using intellij idea ultimate latest version. But whenever I am trying to put a space or special character like comma after " Allowed Values: "11" ", a new line gets generated in the table. Although, I can confirm that the preview of the table looks fine to me.
I am still trying to remove this formatting issue and will send an updated change soon.
There was a problem hiding this comment.
You can format it using Ctrl+Alt+L or use a plugin pipe-table-formatter and For trailing spaces use Settings → Editor → General → Strip trailing spaces
There was a problem hiding this comment.
Thanks @RanabirChakraborty . Although, these didn't work; I had to manually change it in vim.
sudeshnas93
force-pushed
the
JBEAP-24939
branch
4 times, most recently
from
f2dbb7d
to
736803c
Compare
| @@ -77,7 +77,7 @@ The configuration to build the application image is configured in a `build` sect | |||
| | `build.triggers.genericSecret`| Name of the secret containing the WebHookSecretKey for the Generic Webhook | - | The secret must exist in the same namespace or the chart will fail to install - [OpenShift documentation](https://docs.openshift.com/container-platform/latest/cicd/builds/triggering-builds-build-hooks.html#builds-webhook-triggers_triggering-builds-build-hooks) | | |||
| | `build.s2i` | Configuration specific to building with EAP S2I images | - | - | | |||
| | `build.s2i.version` | Version of the EAP S2I images | Defaults to this chart `AppVersion` | - | | |||
| | `build.s2i.jdk` | JDK Version of the EAP S2I images | `"11"` | Allowed Values: `"11"` | | |||
| | `build.s2i.jdk` | JDK Version of the EAP S2I images | `"11"` | Allowed Values: `"11"`, `"17"` | | |||
| | `build.s2i.jdk11.builderImage` | EAP S2I Builder image for JDK 11 | `registry.redhat.io/jboss-eap-7/eap-xp4-openjdk11-openshift-rhel8` | [EAP Documentation](https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_application_platform/7.4/html/getting_started_with_jboss_eap_for_openshift_container_platform/index) | | |||
There was a problem hiding this comment.
Added the JDK17 equivalent images. Thanks.
sudeshnas93
force-pushed
the
JBEAP-24939
branch
from
1cdf284
to
cf0306f
Compare
|
Hello Jeff Mesnil ( @jmesnil ) , |
|
@sudeshnas93 thanks! |
Hello Jeff Mesnil( @jmesnil ), |
Issue: https://issues.redhat.com/browse/JBEAP-24939
Note: Please merge #61 before merging this issue.