Fixing bug #WFLY-1467 by padding the stream to a manifest file with a '\n' #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| @Override | ||
| public int read() throws IOException { |
There was a problem hiding this comment.
What about bulk read operations?
There was a problem hiding this comment.
Currently the code only loads the manifest using new Manifest(stream) which is using the byte per byte read.
I agree that this depends on the JDK manifest implementation. So it might be interesting (as a defensive approach) to wrap the bulk read.
… '\n' if this char is missing at the end of the file. Adding some tests for bunk reading.
|
I have updated the code so it works with bulk read operations. I added some unit tests to prove it. |
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if this char is missing at the end of the file.