Re-organise project to reduce the number of top level items #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
reviewed
Jan 2, 2019
There was a problem hiding this comment.
Glad to see this issue tackled.
Here are a few remarks:
- I think I would have moved the 2 jboss-logging projects to
ext/(where we have ArC and gizmo) as they are more external projects and I think David's plan is to extract them from the Shamrock's tree. @dmlloyd ? - while we're at it, the
reports/directory looks like something we should get rid off in the main tree? I could see how it would be a good idea to commit some reference files of the size of the images in another repository though. @n1hility ? - what's the purpose of what is in the
legacy/directory exactly? - I think I would have kept the
test-framework/directory as a top level element and would have hadintegration-testsas a top level element too. - as for the integration tests artifacts, I would have followed the
shamrock-integration-tests-<whatever>convention so that they are ordered correctly when getting all the artifact names (typically, in Eclipse, the default order is by artifact name and currently all the examples are randomly spread across the list asexampleis at the end of the artifact name). I would have chosen the plural as we have more than one integration test per artifact (but I could see how we could consider the whole artifact as one big integration test so that's not a biggy).
|
Legacy is a PoC that can take an existing war and use Shamrock to launch it like a traditional app server. It was part of the initial requirements that we were able to do this. It should probably be renamed and moved to core. |
stuartwdouglas
force-pushed
the
reorg
branch
2 times, most recently
from
70bb500
to
226dea4
Compare
maxandersen
pushed a commit
to maxandersen/quarkus
that referenced
this pull request
Nov 5, 2022
`JBANG_USES_POWERSHELL=true` was set too late for Jbang to pick it up. It also fixes the fact that jbang on Windows wasn't properly delegating to the downloaded version when using "zero install". Fixes quarkusio#401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.