-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-organise project to reduce the number of top level items #401
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see this issue tackled.
Here are a few remarks:
- I think I would have moved the 2 jboss-logging projects to
ext/
(where we have ArC and gizmo) as they are more external projects and I think David's plan is to extract them from the Shamrock's tree. @dmlloyd ? - while we're at it, the
reports/
directory looks like something we should get rid off in the main tree? I could see how it would be a good idea to commit some reference files of the size of the images in another repository though. @n1hility ? - what's the purpose of what is in the
legacy/
directory exactly? - I think I would have kept the
test-framework/
directory as a top level element and would have hadintegration-tests
as a top level element too. - as for the integration tests artifacts, I would have followed the
shamrock-integration-tests-<whatever>
convention so that they are ordered correctly when getting all the artifact names (typically, in Eclipse, the default order is by artifact name and currently all the examples are randomly spread across the list asexample
is at the end of the artifact name). I would have chosen the plural as we have more than one integration test per artifact (but I could see how we could consider the whole artifact as one big integration test so that's not a biggy).
Legacy is a PoC that can take an existing war and use Shamrock to launch it like a traditional app server. It was part of the initial requirements that we were able to do this. It should probably be renamed and moved to core. |
70bb500
to
226dea4
Compare
`JBANG_USES_POWERSHELL=true` was set too late for Jbang to pick it up. It also fixes the fact that jbang on Windows wasn't properly delegating to the downloaded version when using "zero install". Fixes quarkusio#401
No description provided.