JBTM-3360 ServerLRAFilter is relying on the wrong RESTEasy behavior

jbosstm · Sep 24, 2020 · c46bcc0 · c46bcc0
1 parent ec82270
commit c46bcc0
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/...roxy/api/src/main/java/io/narayana/lra/client/internal/proxy/nonjaxrs/LRAParticipant.java b/...roxy/api/src/main/java/io/narayana/lra/client/internal/proxy/nonjaxrs/LRAParticipant.java
@@ -21,6 +21,7 @@
  */
 package io.narayana.lra.client.internal.proxy.nonjaxrs;
 
+import io.narayana.lra.AnnotationResolver;
 import io.narayana.lra.logging.LRALogger;
 import org.eclipse.microprofile.lra.annotation.AfterLRA;
 import org.eclipse.microprofile.lra.annotation.Compensate;

diff --git a/...al/proxy/nonjaxrs/AnnotationResolver.java → ...a/io/narayana/lra/AnnotationResolver.java b/...al/proxy/nonjaxrs/AnnotationResolver.java → ...a/io/narayana/lra/AnnotationResolver.java
@@ -19,7 +19,7 @@
  * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
  * 02110-1301 USA, or see the FSF site: http://www.fsf.org.
  */
-package io.narayana.lra.client.internal.proxy.nonjaxrs;
+package io.narayana.lra;
 
 import java.lang.annotation.Annotation;
 import java.lang.reflect.Method;

diff --git a/rts/lra/narayana-lra/src/main/java/io/narayana/lra/filter/ServerLRAFilter.java b/rts/lra/narayana-lra/src/main/java/io/narayana/lra/filter/ServerLRAFilter.java
@@ -21,6 +21,7 @@
  */
 package io.narayana.lra.filter;
 
+import io.narayana.lra.AnnotationResolver;
 import io.narayana.lra.Current;
 import io.narayana.lra.client.NarayanaLRAClient;
 import io.narayana.lra.client.internal.proxy.nonjaxrs.LRAParticipant;
@@ -117,7 +118,7 @@ public void filter(ContainerRequestContext containerRequestContext) {
         Method method = resourceInfo.getResourceMethod();
         MultivaluedMap<String, String> headers = containerRequestContext.getHeaders();
         LRA.Type type = null;
-        LRA transactional = method.getDeclaredAnnotation(LRA.class);
+        LRA transactional = AnnotationResolver.resolveAnnotation(LRA.class, method);
         URI lraId;
         URI newLRA = null;
         Long timeout = null;
@@ -151,11 +152,11 @@ public void filter(ContainerRequestContext containerRequestContext) {
             }
         }
 
-        boolean endAnnotation = method.isAnnotationPresent(Complete.class)
-                || method.isAnnotationPresent(Compensate.class)
-                || method.isAnnotationPresent(Leave.class)
-                || method.isAnnotationPresent(Status.class)
-                || method.isAnnotationPresent(Forget.class);
+        boolean endAnnotation = AnnotationResolver.isAnnotationPresent(Complete.class, method)
+                || AnnotationResolver.isAnnotationPresent(Compensate.class, method)
+                || AnnotationResolver.isAnnotationPresent(Leave.class, method)
+                || AnnotationResolver.isAnnotationPresent(Status.class, method)
+                || AnnotationResolver.isAnnotationPresent(Forget.class, method);
 
         if (headers.containsKey(LRA_HTTP_CONTEXT_HEADER)) {
             try {
@@ -168,7 +169,7 @@ public void filter(ContainerRequestContext containerRequestContext) {
             }
         }
 
-        if (method.isAnnotationPresent(Leave.class)) {
+        if (AnnotationResolver.isAnnotationPresent(Leave.class, method)) {
             // leave the LRA
             String compensatorId = getCompensatorId(incommingLRA, containerRequestContext.getUriInfo(), timeout);