Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for JBTM-3239 #1542

Closed
wants to merge 1 commit into from
Closed

Conversation

xstefank
Copy link
Collaborator

@xstefank xstefank commented Jan 6, 2020

issue: https://issues.redhat.com/browse/JBTM-3239

!QA_JTA !QA_JTS_JDKORB !QA_JTS_OPENJDKORB !QA_JTS_JACORB !BLACKTIE !XTS !PERF NO_WIN !AS_TESTS !TOMCAT !JACOCO !mysql !postgres !db2 !oracle !RTS !MAIN LRA

This PR aims to LRA branch because the test uses the new APIs added to the LRA TCK (LRAMetricService) with the vision that it can be one day moved to the specification TCK and to prevent replication. However, the issue affects the master branch too and the fix must be backported to the master branch.


new NarayanaLRARecovery().waitForEndPhaseReplay(lra);

Assert.assertEquals(3,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for why we checking for 3 repeated calls instead of just two is https://issues.redhat.com/browse/JBTM-3163. However, the test will be correct even after the JBTM-3163 is fixed because waitForEndPhaseReplay(lra) will do the recovery twice (however unnecessary so I will fix this test after this issue is fixed)

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

QA_JTS_JACORB profile tests failed (http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_JACORB,jdk=jdk8.latest,label=linux/830/): Narayana rebase on failed. Please rebase it manually

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@xstefank
Copy link
Collaborator Author

I will include this test with the fix for JBTM-3239

@xstefank xstefank closed this Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants