Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBTM-3280 unignore time limit is not failing on ci + JBTM-3283 fixing -Dit.test used #1594

Conversation

ochaloup
Copy link
Contributor

@ochaloup ochaloup commented Apr 9, 2020

https://issues.redhat.com/browse/JBTM-3280
https://issues.redhat.com/browse/JBTM-3283

Un-ignoring TckTests#timeLimit as after testing it seems it was fixed meanwhile by some other fix.
Plus, fixing the -Dit.test when used with TckRecoveryTests.

Thanks to @xstefank to find the reason and the fix.

LRA JDK11
!MAIN !QA_JTA !QA_JTS_JDKORB !QA_JTS_OPENJDKORB !QA_JTS_JACORB !BLACKTIE !XTS !PERF NO_WIN !RTS !AS_TESTS !TOMCAT !JACOCO

…g on CI anymore

This was probably fixed by some other PR provided to the Narayana LRA
codebase meanwhile. It's not obvious which could be the cause of this
stopped to fail on the CI. Prior to that it was not reproducible on
local machine but it was failing on CI.
@jbosstm-bot
Copy link

Copy link
Collaborator

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as it fixes the issue, but I would prefer to have the only single property set in the arquillian.xml which would get populated in the pom.xml. This is just a personal preference as I find the string harder to parse for people now :) -- not something that should block the merge.

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@ochaloup ochaloup added the Hold label Apr 9, 2020
@ochaloup
Copy link
Contributor Author

ochaloup commented Apr 9, 2020

I found thorntail trace logging properties do not work. I need to verify in details.

… parsing arguments for container and startup
@ochaloup ochaloup force-pushed the JBTM-3280-unignore-time-limit-is-not-failing-on-ci branch from 049a76e to 94fd316 Compare April 9, 2020 14:18
@ochaloup ochaloup removed the Hold label Apr 9, 2020
@ochaloup
Copy link
Contributor Author

ochaloup commented Apr 9, 2020

the main trouble with the parsing of the arguments and especially with understanding its existence was the version of thorntail. E.g. the debug params were not used at all. With version 2.6.0.Final I don't experience the problem of the debug or parsing.

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@ochaloup ochaloup merged commit 42c17bc into jbosstm:master Apr 9, 2020
@ochaloup
Copy link
Contributor Author

ochaloup commented Apr 9, 2020

I'm merging this as the CI passed and the it.test works fine on my laptop and the properties (especially the debug.tck one) really start debugging session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants