Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBTM-3295] LRA CDI when fails on non providing @Compensate/@AfterLRA… #1602

Merged

Conversation

ochaloup
Copy link
Contributor

… method has to show the problematic classname

https://issues.redhat.com/browse/JBTM-3295

LRA
!MAIN !QA_JTA !QA_JTS_JDKORB !QA_JTS_OPENJDKORB !QA_JTS_JACORB !BLACKTIE !XTS !PERF NO_WIN !RTS !AS_TESTS !TOMCAT !JACOCO

… method has to show the problematic classname
@ochaloup ochaloup requested a review from mmusgrov April 16, 2020 23:46
@jbosstm-bot
Copy link

Copy link
Collaborator

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@jbosstm-bot
Copy link

Copy link
Contributor

@mmusgrov mmusgrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate of JBTM-3291 which @mayankkunwar is working on. The issue includes more than just the message so the PR is good. The issue description wasn't clear enough for you to infer that (sorry).

Can you update the links between the JIRAs.

@mmusgrov
Copy link
Contributor

And the single TCK test failure is a known issue and PR #1603 skips the test.

@ochaloup
Copy link
Contributor Author

@mmusgrov no, this is not a duplicate. It's just reporting that the classname is not printed on the error.
The duplicate was my other issue https://issues.redhat.com/browse/JBTM-3296 which I've already closed.

Thanks for the approval.

@ochaloup ochaloup merged commit aac3b7e into jbosstm:master Apr 17, 2020
@mmusgrov
Copy link
Contributor

@ochaloup It is a duplicate. If you click through to the link I provided in my comment you will see that JBTM-3291 asks for the error message to include the class name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants