Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JBTM-3376 clean CMR integration test 4.17 #1701

Merged
merged 2 commits into from Oct 26, 2020
Merged

JBTM-3376 clean CMR integration test 4.17 #1701

merged 2 commits into from Oct 26, 2020

Conversation

ochaloup
Copy link
Contributor

@ochaloup ochaloup commented Oct 22, 2020 •
edited

https://issues.redhat.com/browse/JBTM-3376

Making the test working on older WildFly app servers.
Making the test better in way of understanding the failures.

!MAIN AS_TESTS
!QA_JTS_JACORB !QA_JTA !XTS !QA_JTS_JDKORB

@jbosstm-bot
Copy link

Started testing this pull request with MAIN profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-417/PROFILE=MAIN,jdk=jdk7.latest,label=linux/105/

@ochaloup ochaloup changed the title Jbtm 3376 clean cmr integration test 4.17 JBTM-3376 clean CMR integration test 4.17 Oct 22, 2020
@jbosstm-bot
Copy link

MAIN profile tests passed - Job complete http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-417/PROFILE=MAIN,jdk=jdk7.latest,label=linux/105/

mmusgrov
mmusgrov approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@mmusgrov mmusgrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. I must admit I didn't fully understand the impact of the changes, do you think we accidentally back ported the CMR config file at some point in the past?

This PR fixes the failure on the AS_TESTS axis but that axis did not run for this PR since the btny-pulls-narayana-417 jenkins job does not include the AS_TESTS axis. Do you think we should add the axis to that job?

@ochaloup
[JBTM-3376] clean CMRIntegrationTest to be more transparent and get m…
6925c06 
…ore when fails
@ochaloup
[JBTM-3376] changing standalone cmr configuration to be runnable with…
4c1bc67 
… older JBoss AS/WildFly

The current standalone-cmr.xml configuration file expects an higher
version of WildFly to be run with (something like WildFly 10).
Changing the xml to be runnable with older versions helps the tests
to be working on them.
@ochaloup ochaloup force-pushed the JBTM-3376-clean-CMRIntegrationTest-4.17 branch from d29e9ee to 4c1bc67 Compare October 22, 2020 12:26
@jbosstm-bot
Copy link

Started testing this pull request with MAIN profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-417/PROFILE=MAIN,jdk=jdk7.latest,label=linux/106/

@ochaloup
Copy link
Contributor Author

ochaloup commented Oct 22, 2020 •
edited

@mmusgrov the AS_TESTS axis runs with the EAP6.x job.
Regarding this change and the 4.17 pull job - the there is no much sense to add the AS_TESTS axis to the 4.17 upstream job. The CMR functionality has not been integrated with jboss as 7.2.0.
If you think I can add the AS_TESTS axis to the job but I will still need to disable the CMR testing for the jboss-as 7.2.0 as the CMR test will be failing either way.

@jbosstm-bot
Copy link

MAIN profile tests passed - Job complete http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-417/PROFILE=MAIN,jdk=jdk7.latest,label=linux/106/

@ochaloup
Copy link
Contributor Author

There is a strange failure in the test. It seems to be related with timing but I need to check in details.

Running com.hp.mwtests.ts.jta.commitmarkable.integration.CMRIntegrationTest
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 28.912 sec <<< FAILURE!

Results :
Failed tests:   testCMR(com.hp.mwtests.ts.jta.commitmarkable.integration.CMRIntegrationTest): expected:<100> but was:<99>

@ochaloup
Copy link
Contributor Author

I'm merging this as from what I can see from the testing and rerunning on the CI this seems to be a intermittent failure not a functionality issue.

@ochaloup ochaloup merged commit faa13c9 into jbosstm:4.17 Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmusgrov mmusgrov mmusgrov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ochaloup @jbosstm-bot @mmusgrov