JBTM-3472 Produce jakarta artifact for narayana-jta #1824

@beikov our CI script considers the SPI changes for tests but the PR description has to be in the right format (not documented, sorry for that) It requires the full http address to the PR) I changed that and the later test executions have passed (the CORE and XTS).

The run of the AS_TESTS axis is not fully stable in our CI (we experience time to time intermittent failures). The CI run shows failures at StatelessTimeoutTestCase and DatabaseTimerServiceMultiNodeTestCase which are known not related failures which we are working on address.
Then I can see three more which we need to investigate: DupliciteApplicationPathTestCase, JdrReportManagmentTestCase,ConsoleAccessLogTestCase, if they're just intermittent or somehow related to this PR.

mmusgrov · 2021-04-23T12:03:17Z

FYI I promoted the release of 7.6.1.Final (the tag is https://github.com/jbosstm/jboss-transaction-spi/releases/tag/7.6.1.Final) and hopefully it will eventually be available from maven central (which can take hours).

ochaloup

@beikov I think the fix is nice. Just before merging we need to update the SPI version to 7.6.1.Final at pom.xml (https://github.com/jbosstm/narayana/blob/5.11.1.Final/pom.xml#L483) as discussed already.
Plus, I think the new artifact should be part of the narayana-full.zip. That's a release zip artifact provided as a bundle for anybody looking for a all narayana artifacts. You need to update the assembly/bin.xml at https://github.com/jbosstm/narayana/blob/master/narayana-full/src/main/assembly/bin.xml#L107. I assume in the similar fashion as it's done for narayana-jta.

@mmusgrov I have few doubts on how Narayana project expects to work with this new mvn artifact

this change does not consider any testing from Narayana perspective (e.g. when some Jakarta API is changed, I I understand the changeset correctly). Is that ok or should that be addressed somehow? (a note: the current run of the CI it's only important to check if compiles, no other axis is needed to be run as there is no relation to jakarta)
for WildFly we use the narayana-jts-idlj.jar dependency. Should there be created some naryana-jts-idlj-jakarta.jar and provided to WildFly?

jbosstm-bot · 2021-04-27T08:42:11Z

Started testing this pull request with QA_JTA profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=jdk8.latest,label=linux/50/

jbosstm-bot · 2021-04-27T08:42:14Z

Started testing this pull request with XTS profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=XTS,jdk=jdk8.latest,label=linux/50/

jbosstm-bot · 2021-04-27T08:42:14Z

Started testing this pull request with AS_TESTS profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=AS_TESTS,jdk=jdk8.latest,label=linux/50/

jbosstm-bot · 2021-04-27T08:42:16Z

Started testing this pull request with MAIN profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=jdk8.latest,label=linux/50/

jbosstm-bot · 2021-04-27T08:42:16Z

Started testing this pull request with QA_JTS_OPENJDKORB profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_OPENJDKORB,jdk=jdk8.latest,label=linux/50/

jbosstm-bot · 2021-04-27T08:42:16Z

Started testing this pull request with TOMCAT profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=TOMCAT,jdk=jdk8.latest,label=linux/50/

jbosstm-bot · 2021-04-27T09:46:27Z

QA_JTS_OPENJDKORB profile tests failed (http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_OPENJDKORB,jdk=jdk8.latest,label=linux/50/): qa build failed

jbosstm-bot · 2021-04-27T09:46:28Z

QA_JTA profile tests failed (http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=jdk8.latest,label=linux/50/): qa build failed

jbosstm-bot · 2021-04-27T09:57:17Z

TOMCAT profile tests passed - Job complete http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=TOMCAT,jdk=jdk8.latest,label=linux/50/

jbosstm-bot · 2021-04-27T10:55:03Z

CORE profile tests passed - Job complete http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=jdk8.latest,label=linux/50/

ochaloup

I would like ask for one more adjustment. Otherwise all seems fine.

ochaloup · 2021-04-27T11:31:31Z

ArjunaJTA/narayana-jta-jakarta/pom.xml

+  <properties>
+    <version.jakarta.transaction.jakarta.transaction-api>2.0.0</version.jakarta.transaction.jakarta.transaction-api>
+    <version.jakarta.resource.jakarta.resource-api>2.0.0</version.jakarta.resource.jakarta.resource-api>
+    <version.org.jboss.jboss-transaction-spi>7.6.1.Final</version.org.jboss.jboss-transaction-spi>


To me the PR is good for merge. Just I would like to ask for one more adjustment, please mov the version configuration to root pom.xml. I mean redefine the version 7.6.0 here: https://github.com/jbosstm/narayana/blob/master/pom.xml#L485
and remove the line from this pom.xml.

jbosstm-bot · 2021-04-27T11:52:46Z

XTS profile tests passed - Job complete http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=XTS,jdk=jdk8.latest,label=linux/50/

jbosstm-bot · 2021-04-27T14:02:35Z

AS_TESTS profile tests failed (http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=AS_TESTS,jdk=jdk8.latest,label=linux/50/): AS tests failed

ochaloup

Thank you. Seems good to me. Let's wait for the CI jobs.

jbosstm-bot · 2021-04-27T16:33:22Z

Started testing this pull request with TOMCAT profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=TOMCAT,jdk=jdk8.latest,label=linux/52/

jbosstm-bot · 2021-04-27T16:33:22Z

Started testing this pull request with QA_JTS_OPENJDKORB profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_OPENJDKORB,jdk=jdk8.latest,label=linux/52/

jbosstm-bot · 2021-04-27T16:33:43Z

TOMCAT profile tests failed (http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=TOMCAT,jdk=jdk8.latest,label=linux/52/): narayana build failed

jbosstm-bot · 2021-04-27T16:33:43Z

QA_JTS_OPENJDKORB profile tests failed (http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTS_OPENJDKORB,jdk=jdk8.latest,label=linux/52/): narayana build failed

jbosstm-bot · 2021-04-27T16:35:29Z

Started testing this pull request with MAIN profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=jdk8.latest,label=linux/52/

jbosstm-bot · 2021-04-27T16:35:30Z

Started testing this pull request with XTS profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=XTS,jdk=jdk8.latest,label=linux/52/

jbosstm-bot · 2021-04-27T16:35:30Z

Started testing this pull request with AS_TESTS profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=AS_TESTS,jdk=jdk8.latest,label=linux/52/

jbosstm-bot · 2021-04-27T16:35:32Z

Started testing this pull request with QA_JTA profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=jdk8.latest,label=linux/52/

jbosstm-bot · 2021-04-27T16:35:38Z

CORE profile tests failed (http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=jdk8.latest,label=linux/52/): narayana build failed

jbosstm-bot · 2021-04-27T16:35:38Z

AS_TESTS profile tests failed (http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=AS_TESTS,jdk=jdk8.latest,label=linux/52/): narayana build failed

jbosstm-bot · 2021-04-27T16:35:38Z

QA_JTA profile tests failed (http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=jdk8.latest,label=linux/52/): narayana build failed

jbosstm-bot · 2021-04-27T16:35:38Z

XTS profile tests failed (http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=XTS,jdk=jdk8.latest,label=linux/52/): narayana build failed

jbosstm-bot · 2021-04-28T07:52:15Z

Started testing this pull request with MAIN profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=jdk8.latest,label=linux/57/

jbosstm-bot · 2021-04-28T10:13:57Z

CORE profile tests passed - Job complete http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=jdk8.latest,label=linux/57/

beikov · 2021-04-29T07:16:23Z

The SPI artifacts are on maven central now. Is there anything else you would like me to do before you merge this PR?

mmusgrov

Looks good and ready to merge.

mmusgrov requested review from mmusgrov and ochaloup April 22, 2021 13:56

mmusgrov changed the title ~~Produce jakarta artifact for narayana-jta~~ JBTM-3472 Produce jakarta artifact for narayana-jta Apr 26, 2021

ochaloup suggested changes Apr 26, 2021

View reviewed changes

beikov force-pushed the jakarta branch from 67941f1 to a9bafc3 Compare April 27, 2021 08:37

ochaloup suggested changes Apr 27, 2021

View reviewed changes

Produce jakarta artifact for narayana-jta

1c82b25

beikov force-pushed the jakarta branch from a9bafc3 to 1c82b25 Compare April 27, 2021 12:25

ochaloup approved these changes Apr 27, 2021

View reviewed changes

mmusgrov approved these changes Apr 29, 2021

View reviewed changes

mmusgrov merged commit 3bebcb2 into jbosstm:master Apr 29, 2021

beikov deleted the jakarta branch April 29, 2021 09:38

JBTM-3472 Produce jakarta artifact for narayana-jta #1824

JBTM-3472 Produce jakarta artifact for narayana-jta #1824

Conversation

beikov commented Apr 22, 2021 • edited by ochaloup

jbosstm-bot commented Apr 22, 2021

mmusgrov commented Apr 22, 2021

jbosstm-bot commented Apr 22, 2021

jbosstm-bot commented Apr 22, 2021

jbosstm-bot commented Apr 22, 2021

jbosstm-bot commented Apr 22, 2021

jbosstm-bot commented Apr 22, 2021

jbosstm-bot commented Apr 22, 2021

jbosstm-bot commented Apr 22, 2021

jbosstm-bot commented Apr 22, 2021

jbosstm-bot commented Apr 22, 2021

jbosstm-bot commented Apr 22, 2021

jbosstm-bot commented Apr 22, 2021

jbosstm-bot commented Apr 23, 2021

beikov commented Apr 23, 2021

ochaloup commented Apr 23, 2021 • edited

mmusgrov commented Apr 23, 2021

ochaloup left a comment • edited

Choose a reason for hiding this comment

jbosstm-bot commented Apr 27, 2021

jbosstm-bot commented Apr 27, 2021

jbosstm-bot commented Apr 27, 2021

jbosstm-bot commented Apr 27, 2021

jbosstm-bot commented Apr 27, 2021

jbosstm-bot commented Apr 27, 2021

jbosstm-bot commented Apr 27, 2021

jbosstm-bot commented Apr 27, 2021

jbosstm-bot commented Apr 27, 2021

jbosstm-bot commented Apr 27, 2021

ochaloup left a comment

Choose a reason for hiding this comment

ochaloup Apr 27, 2021

Choose a reason for hiding this comment

beikov Apr 27, 2021

Choose a reason for hiding this comment

jbosstm-bot commented Apr 27, 2021

jbosstm-bot commented Apr 27, 2021

ochaloup left a comment

Choose a reason for hiding this comment

jbosstm-bot commented Apr 27, 2021

jbosstm-bot commented Apr 27, 2021

jbosstm-bot commented Apr 27, 2021

jbosstm-bot commented Apr 27, 2021

jbosstm-bot commented Apr 27, 2021

jbosstm-bot commented Apr 27, 2021

jbosstm-bot commented Apr 27, 2021

jbosstm-bot commented Apr 27, 2021

jbosstm-bot commented Apr 27, 2021

jbosstm-bot commented Apr 27, 2021

jbosstm-bot commented Apr 27, 2021

jbosstm-bot commented Apr 27, 2021

jbosstm-bot commented Apr 28, 2021

jbosstm-bot commented Apr 28, 2021

beikov commented Apr 29, 2021

mmusgrov left a comment

Choose a reason for hiding this comment

beikov commented Apr 22, 2021 •

edited by ochaloup

ochaloup commented Apr 23, 2021 •

edited

ochaloup left a comment •

edited