JBTM-3509 Small optimisations in setting Transaction Timeout #1870
Conversation
|
Author is not the 'narayana' contributor, to permit PR being run members of jbosstm can write comment of text: TESTIT |
|
TESTIT |
|
Started testing this pull request with TOMCAT profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=TOMCAT,jdk=jdk8.latest,label=linux/82/ |
|
Started testing this pull request with MAIN profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=jdk8.latest,label=linux/82/ |
|
Started testing this pull request with QA_JTA profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=jdk8.latest,label=linux/82/ |
|
Started testing this pull request with AS_TESTS profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=AS_TESTS,jdk=jdk8.latest,label=linux/82/ |
|
TOMCAT profile tests failed (http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=TOMCAT,jdk=jdk8.latest,label=linux/82/): Narayana Tomcat tests failed H2 |
|
CORE profile tests passed - Job complete http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=CORE,jdk=jdk8.latest,label=linux/82/ |
There was a problem hiding this comment.
Testing this against the CORE/MAIN axis is sufficient so I will review it now (but may as well allow the other axes to finish since they have already started).
The tomcat axis failed with could not locate org.jboss.narayana:common:pom:5.9.0.Final which does exist (https://mvnrepository.com/artifact/org.jboss.narayana/common/5.9.0.Final) so it can be ignored as a transient failure.
|
QA_JTA profile tests passed - Job complete http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=jdk8.latest,label=linux/82/ |
| { | ||
| _timeouts.set(new Integer(seconds)); |
There was a problem hiding this comment.
FWIW, doing new Integer(int) is deprecated in most recent JVMs and ill be removed. To be future-proof, I'd suggest consistently changing all code to use the better Integer.valueOf(int) variant.
There was a problem hiding this comment.
We do that quite a lot so thanks for the tip
|
AS_TESTS profile tests passed - Job complete http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=AS_TESTS,jdk=jdk8.latest,label=linux/82/ |
https://issues.redhat.com/browse/JBTM-3509
MAIN CORE TOMCAT AS_TESTS !RTS JACOCO !XTS QA_JTA QA_JTS_JACORB QA_JTS_JDKORB QA_JTS_OPENJDKORB !BLACKTIE !PERF !LRA !NO_WIN !DB_TESTS mysql db2 postgres oracle