[JBTM-3553] The procedure to configure Oracle DB needs to be updated #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjenkinson
reviewed
Dec 8, 2021
|
|
||
| return (String) _profile.get(profileName + "_Host"); | ||
| } | ||
| return (String) _profile.get(profileName + "_DatabaseName"); |
There was a problem hiding this comment.
I think you should consider to remove this serviceName function (and please see below for some more context)
There was a problem hiding this comment.
Ops, copy&paste mistake. _DatabaseName at line 93 should have been _ServiceName. Also, the function I was calling was getOrDefault...I will update the PR. Thanks for spotting that :-)
tomjenkinson
reviewed
Dec 8, 2021
tomjenkinson
reviewed
Dec 8, 2021
|
Started testing this pull request with QA_JTA profile: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=jdk8.latest,label=linux/531/ |
|
QA_JTA profile tests passed - Job complete http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=QA_JTA,jdk=jdk8.latest,label=linux/531/ |
tomjenkinson
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses JBTM-3553.
To test:
QA_JTA
To exclude:
!CORE !TOMCAT !AS_TESTS !RTS !JACOCO !XTS !QA_JTS_JACORB !QA_JTS_JDKORB !QA_JTS_OPENJDKORB !PERF !LRA !DB_TESTS !mysql !db2 !postgres !oracle