Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JBTM-3756 update bean discovery mode in lra-client #2093

Merged
merged 1 commit into from Mar 1, 2023
Merged

JBTM-3756 update bean discovery mode in lra-client #2093

merged 1 commit into from Mar 1, 2023

Conversation

mmusgrov
Copy link
Contributor

@mmusgrov mmusgrov commented Mar 1, 2023

@mmusgrov mmusgrov mentioned this pull request Mar 1, 2023
Closed
@manovotn
Copy link
Contributor

manovotn commented Mar 1, 2023

I can see a total of 5 beans.xml files in Narayana LRA. I know that the Quarkus issue (quarkusio/quarkus#31378) only mentions client module, but it might be worth changing all of them?

@mmusgrov
Copy link
Contributor Author

mmusgrov commented Mar 1, 2023 •
edited

I can see a total of 5 beans.xml files in Narayana LRA. I know that the Quarkus issue (quarkusio/quarkus#31378) only mentions client module, but it might be worth changing all of them?

I did check all of them.
@manovotn I've also changed the schema version, would you mind taking another look.

marcosgopen
marcosgopen approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@marcosgopen marcosgopen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

manovotn
manovotn approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @mmusgrov, thanks!

@mmusgrov mmusgrov merged commit b132693 into jbosstm:main Mar 1, 2023
@mmusgrov mmusgrov deleted the JBTM-3756 branch March 1, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

@marcosgopen marcosgopen marcosgopen approved these changes

@jmfinelli jmfinelli Awaiting requested review from jmfinelli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mmusgrov @manovotn @marcosgopen