Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBTM-2222 Do not move the GAV for txframework #819

Merged
merged 1 commit into from Apr 7, 2015

Conversation

tomjenkinson
Copy link
Contributor

!BLACKTIE !QA_JTA !QA_JTS_JACORB !PERF !MAIN

Requires: jbosstm/jboss-as#36

@tomjenkinson tomjenkinson force-pushed the JBTM-2222 branch 3 times, most recently from 00ab717 to bfd801d Compare March 25, 2015 15:22
@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@tomjenkinson
Copy link
Contributor Author

Hi Gytis,

Please can you have a look. The issue was that the maven coordinates for the old txf jar moved. I happen to agree with the forum poster that this is not the best way to deprecate given the maven distribution.

All my tests seem to suggest its OK. Maybe you have an opinion on where each of the tests ended up (i.e. the compensations vs txf folder).

It require a small AS update which I have linked to.

Thanks,
Tom

@gytis
Copy link
Contributor

gytis commented Mar 26, 2015

Hi Tom,

overall I think it looks correct.
Only not sure about .sagas. test. This doesn't test neither compensations nor txframework directly, but it's useful. And it will be gone once we remove txframework completely. So maybe it might be good to keep it in compensations, just in case?

@tomjenkinson
Copy link
Contributor Author

Sure, good spot. "Compensations" does depend on "txframework" for some of the impl stuff so that will need moving before deleting the txf stuff later on but the .sagas test could have been missed.

Thanks for the review - once it passes I will get it merged

@gytis
Copy link
Contributor

gytis commented Mar 26, 2015

sure, no problem.

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

tomjenkinson added a commit that referenced this pull request Apr 7, 2015
JBTM-2222 Do not move the GAV for txframework
@tomjenkinson tomjenkinson merged commit 1f37e61 into jbosstm:master Apr 7, 2015
@tomjenkinson tomjenkinson deleted the JBTM-2222 branch June 1, 2016 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants