New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JBTM-2222 Do not move the GAV for txframework #819
Conversation
00ab717
to
bfd801d
Compare
Started testing this pull request with XTS profile: http://albany.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=XTS,jdk=jdk7.latest,label=linux/999/ |
XTS profile tests passed - Job complete http://albany.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=XTS,jdk=jdk7.latest,label=linux/999/ |
Hi Gytis, Please can you have a look. The issue was that the maven coordinates for the old txf jar moved. I happen to agree with the forum poster that this is not the best way to deprecate given the maven distribution. All my tests seem to suggest its OK. Maybe you have an opinion on where each of the tests ended up (i.e. the compensations vs txf folder). It require a small AS update which I have linked to. Thanks, |
Hi Tom, overall I think it looks correct. |
Sure, good spot. "Compensations" does depend on "txframework" for some of the impl stuff so that will need moving before deleting the txf stuff later on but the .sagas test could have been missed. Thanks for the review - once it passes I will get it merged |
sure, no problem. |
Started testing this pull request with XTS profile: http://albany.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=XTS,jdk=jdk7.latest,label=linux/1000/ |
XTS profile tests passed - Job complete http://albany.eng.hst.ams2.redhat.com/job/btny-pulls-narayana/PROFILE=XTS,jdk=jdk7.latest,label=linux/1000/ |
JBTM-2222 Do not move the GAV for txframework
!BLACKTIE !QA_JTA !QA_JTS_JACORB !PERF !MAIN
Requires: jbosstm/jboss-as#36