[JBTM-3203] enabling XTS over SSL with correct bom with jakarta depen… #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjenkinson
approved these changes
Oct 7, 2019
There was a problem hiding this comment.
Hi @ochaloup I am approving as it looks correct but as CI will not get this far right now, please can you confirm you have successfully ran it locally?
|
Started testing this pull request: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-quickstart/161/ |
|
I run the XTS tests locally and it passed fine. I'm going to merge this as Tom pointed out there is expected LRA failures on linux CI job which are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/JBTM-3203
WFLY18 is released, no need of temporary fix #259 anymore
Now the quickstart can be enabled with the fix.