Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jbtm 3699 & jbtm 3158 #420

Merged
merged 2 commits into from Dec 21, 2022
Merged

Jbtm 3699 & jbtm 3158 #420

merged 2 commits into from Dec 21, 2022

Conversation

jmfinelli
Copy link
Contributor

This PR migrates jta-and-hibernate-standalone to jakarta and addresses JBTM-3158

@jmfinelli jmfinelli changed the base branch from main to JBTM-3699 December 21, 2022 10:28
@jmfinelli jmfinelli removed the request for review from mmusgrov December 21, 2022 10:28
@jmfinelli jmfinelli added the NoCI marking pull request as for not running CI tests label Dec 21, 2022
@jbosstm-bot
Copy link

CI was disabled as NoCI label is applied, to trigger it manually go to: http://narayanaci1.eng.hst.ams2.redhat.com//job/btny-pulls-narayana-quickstart/buildWithParameters?delay=0sec&pullNumber=origin/pull/420/head

marcosgopen
marcosgopen reviewed Dec 21, 2022
View reviewed changes
Copy link
Contributor

@marcosgopen marcosgopen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmfinelli for this PR!

jta-and-hibernate-standalone/src/test/java/org/jboss/narayana/quickstart/jta/TestCase.java Outdated Show resolved Hide resolved
@marcosgopen marcosgopen merged commit 1489dff into jbosstm:JBTM-3699 Dec 21, 2022
@marcosgopen
Copy link
Contributor

Thanks @jmfinelli for addressing my comments! I therefore approve your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosgopen marcosgopen marcosgopen left review comments

Assignees
No one assigned
Labels
NoCI marking pull request as for not running CI tests
Projects
None yet
Milestone
No milestone
3 participants
@jmfinelli @jbosstm-bot @marcosgopen