JBIDE-11436 JBIDE-19826 update to use new lic... ...ense terms (new address); clean up site/category.xml #420
Conversation
nickboldt
force-pushed
the
JBIDE-11436
branch
3 times, most recently
from
4a55983
to
8c35a54
Compare
|
+1 if you remove the pointless license source feature |
|
What about amending previous commit rather than adding a fix commit? A beauty of code review is that we don't need to keep such level of detail in the actual history. |
|
I just wanted to show you my changes. But yes, I can squash. #thereISquashedIt |
|
+1 to merge it. You can also add an "Also-By: Nick Boldt nboldt@redhat.com" line to the commit message if you want. |
|
|
||
| <category-def label="JBoss Tools Base Nightly Build Update Site" name="AllFeatures"> |
There was a problem hiding this comment.
are these new reformatting just for show or have some meaning for this ?
There was a problem hiding this comment.
reduction of number of lines (make file more compact & terse) and removal of pointless metadata such as:
url="features/org.jboss.tools.test.feature.source_0.0.0.jar" version="0.0.0"
JBIDE-11436 JBIDE-19826 update to use new license terms (new address); clean up site/category.xml add org.jboss.tools.foundation.license.feature.source remove feature_ja.properties JBIDE-11436 remove license.feature.source per Fred's request JBIDE-11436 add build.properties into license feature so that it can be used in downstream builds (Maven requested it) JBIDE-11436 don't define anything but providerName and license in org.jboss.tools.foundation.license.feature/feature.properties; move label and description to org.jboss.tools.foundation.license.feature/feature.xml so not inherited by downstream projects
|
@alexeykazakov @dgolovin @maxandersen can you merge this or explain why we shouldn't? |
|
+1 to merge it ASAP |
|
pushed to master. |
add org.jboss.tools.foundation.license.feature.source