Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FUSETOOLS-2967 - Fix UI tests in PR job #1365

Merged
merged 1 commit into from
May 16, 2018

Conversation

tsedmik
Copy link
Contributor

@tsedmik tsedmik commented May 15, 2018

https://issues.jboss.org/browse/FUSETOOLS-2967

  • change the update site for OpenShift feature from snapshot to staging

Signed-off-by: Tomáš Sedmík tsedmik@redhat.com

Pull Request Checklist

After this checklist is all checked or PR provides explanations for possible pass-through, please put the label "Ready for review" on the PR.

General

  • Did you use the Jira Issue number in the commit comments?
  • Did you set meaningful commit comments on each commit?
  • Did you sign off all commits for this PR? (git commit -s -m "jira issue number - your commit comment")

Functional

  • Did the CI job report a successful build?
  • Is the non-happy path working, too?

Maintainability

  • Are all Sonar reported issues fixed or can they be ignored?
  • Is there no duplicated code?
  • Are method-/class-/variable-names meaningful?

Tests

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Do we need a new UI test?

Legal

  • Have you used the correct file header copyright comment?
  • Have you used the correct year in the headers of new files?

https://issues.jboss.org/browse/FUSETOOLS-2967

- change the update site for OpenShift feature from snapshot to staging

Signed-off-by: Tomáš Sedmík <tsedmik@redhat.com>
@tsedmik tsedmik requested a review from a team as a code owner May 15, 2018 12:32
@tsedmik tsedmik merged commit a07f17c into jbosstools:master May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants