Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FUSETOOLS-3461 - delete invalid MANIFEST.MF on new places #1681

Merged

Conversation

apupier
Copy link
Member

@apupier apupier commented Mar 17, 2021

an invalid META-INF/MANIFEST.MF is generated by jst.utility facet. A
workaround was previously provided in Fuse Tooling code to delete the
invalid generated META-INF folder. Starting with Eclipse 2021-03, the
default folder to generated this file has been moved from src to
src/main/java. So added this folder to be deleted to have it working
both in previous version of Eclipse and newer version.

it was detected by test
org.fusesource.ide.projecttemplates.tests.integration.wizards.FuseIntegrationProjectCreatorRunnableForOSESringBootIT.additionalChecks(IProject)

it is fixing regression after Target platform upgrade to Eclipse 2021-03

an invalid META-INF/MANIFEST.MF is generated by jst.utility facet. A
workaround was previously provided in Fuse Tooling code to delete the
invalid generated META-INF folder. Starting with Eclipse 2021-03, the
default folder to generated this file has been moved from src to
src/main/java. So added this folder to be deleted to have it working
both in previous version of Eclipse and newer version.

it was detected by test
org.fusesource.ide.projecttemplates.tests.integration.wizards.FuseIntegrationProjectCreatorRunnableForOSESringBootIT.additionalChecks(IProject)

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier requested a review from a team as a code owner March 17, 2021 08:28
@apupier apupier added the PRIO label Mar 17, 2021
@apupier apupier merged commit d55f7ae into jbosstools:master Mar 17, 2021
@apupier apupier deleted the FUSETOOLS-3461-fixbadManifestGenerated branch March 17, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants