Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure mirror options #34

Closed
wants to merge 3 commits into from

Conversation

rbioteau
Copy link
Contributor

Make Mirror options configurable

@mickaelistria
Copy link
Contributor

This seems good to me. Can you please just cherry-pick 561dc4d on top of current HEAD on master, so that all that would only appear as a single commit?
Then you can directly update this pull request (without creating a new one) with a push --force on your configure-mirror-options branch.

@mickaelistria
Copy link
Contributor

Also, I'm curious: what's your use-case behind this contribution?

@rbioteau
Copy link
Contributor Author

The hardcoded properties used by default doesn't retrieve all needed dependencies for our target platform.
Using followStrictOnly = false, make p2 go deeper in dependency resolution.

@mickaelistria
Copy link
Contributor

So it's only the followStirctOnly? I'm now wondering whether this followStrictOnly attribute shouldn't be derived from the planner/slicer parameter. If it's the only use-case, I suggest we try an implementation that makes followStrictDependency set to true in slicer mode.
WDYT?

@rbioteau
Copy link
Contributor Author

I'm not confident enough with all those concept to assume that.

@mickaelistria
Copy link
Contributor

Well, we are using includeMode=slicer and are fine with followStrictOnly=true. You need followStrictOnly=false, are you using planner? If you're using planner, then it means that we can assume that followStrictOnly==(includeMode==SLICER). So it would probably be smarter to set the followStrictDependency according to the includeMode than to add a parameter for it.

@rbioteau
Copy link
Contributor Author

We do use planner mode. Do you have a tool/hint to analyse a feature dependency ?
Because a drawback with followStrictOnly == false is that our target repo become very huge with a lot of useless stuff...

So either I use this option and I'm sure that I've got all I need to have a valid TP. Or use with followStrictOnly==true and I need to add my dependency one by one regarding the validation result... That's qkind of boring.

@mickaelistria
Copy link
Contributor

That's the drawback of planner: you don't really know all you'll get. That's why we're using slicer mode (aka followStrictOnly=true), but it requires more effort to set it up without forgetting anything. In order to make sure the target platform doesn't miss anything and that all transitive dependencies are there, we use the target-platform-validation plugin which is part of tycho-extras. It will fail if something is missing, so you more easily know what you need to include.
HTH

@mickaelistria
Copy link
Contributor

Closed in favor of #34 . note that with #64 , it should make it easier to use the mojo in planner mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants