JBIDE-18186 - support for module-alias in modules.xml inside wildfly/eap #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| File modulexml = new File(layeredPath, "module.xml"); | ||
| String alias = new ModuleAliasUtil().getAlias(modulexml); | ||
| if( alias != null ) { | ||
| return new ModuleSlot(alias).getJars(modulesFolder); |
There was a problem hiding this comment.
what happens if this alias points to a chain of module alias to the same folder ? this would be an endless loop....too arcance to think it will happen ?
There was a problem hiding this comment.
It definitely could happen, though it'd represent a broken installation and probably not happen often at all ;) I can work on adding more careful checking for cr2 to detect loops...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.