New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JBIDE-18186 - support for module-alias in modules.xml inside wildfly/eap #263
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
42 changes: 42 additions & 0 deletions
42
...e/src/org/jboss/ide/eclipse/as/classpath/core/runtime/cache/internal/ModuleAliasUtil.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
/******************************************************************************* | ||
* Copyright (c) 2014 Red Hat, Inc. | ||
* Distributed under license by Red Hat, Inc. All rights reserved. | ||
* This program is made available under the terms of the | ||
* Eclipse Public License v1.0 which accompanies this distribution, | ||
* and is available at http://www.eclipse.org/legal/epl-v10.html | ||
* | ||
* Contributors: | ||
* Red Hat, Inc. - initial API and implementation | ||
******************************************************************************/ | ||
package org.jboss.ide.eclipse.as.classpath.core.runtime.cache.internal; | ||
|
||
import java.io.File; | ||
import java.io.FileInputStream; | ||
import java.io.IOException; | ||
|
||
import org.jboss.ide.eclipse.as.core.util.FileUtil; | ||
import org.jboss.tools.foundation.core.xml.XMLMemento; | ||
|
||
public class ModuleAliasUtil { | ||
public String getAlias(File moduleXml) { | ||
if( moduleXml.exists()) { | ||
try { | ||
String contents = FileUtil.getContents(moduleXml); | ||
if( contents != null ) { | ||
XMLMemento memento = XMLMemento.createReadRoot(new FileInputStream(moduleXml)); | ||
if( memento != null ) { | ||
String nodeName = memento.getNodeName(); | ||
if( "module-alias".equals(nodeName)) { | ||
String targName = memento.getString("target-name"); | ||
if( targName != null ) | ||
return targName; | ||
} | ||
} | ||
} | ||
} catch(IOException ce) { | ||
// Ignore | ||
} | ||
} | ||
return null; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens if this alias points to a chain of module alias to the same folder ? this would be an endless loop....too arcance to think it will happen ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It definitely could happen, though it'd represent a broken installation and probably not happen often at all ;) I can work on adding more careful checking for cr2 to detect loops...