[JBIDE-25855] add org.jboss.tools.openshift.core as friend #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
|
@robstryker please review |
1 similar comment
|
@robstryker please review |
|
Isn't it more reasonable to make this class API? |
|
@robstryker +1 for making this API. But then I bet there are more potential candidates like StandardModuleRestartBehaviorController, etc.? |
|
You can use these classes / subsystems without extending them. Most of the others probably aren't designed for subclassing and haven't been tested as thoroughly. So I'm not in any hurry to make them API until someone claims they need it. |
|
dropping this in favor of #568 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.