JBIDE-25855 - move publish controller to API

[robstryker]

Signed-off-by: Rob Stryker rob@oxbeef.net

[rhdevelopers-ci]

SonarQube analysis reported 11 issues

• 4 critical
• 3 major
• 3 minor
• 1 info

Top 10 issues

1. StandardFileSystemPublishController.java#L298: Refactor this method to reduce its Cognitive Complexity from 27 to the 15 allowed.
2. StandardFileSystemPublishController.java#L519: Refactor this method to reduce its Cognitive Complexity from 37 to the 15 allowed.
3. StandardFileSystemPublishController.java#L776: Refactor this method to reduce its Cognitive Complexity from 19 to the 15 allowed.
4. StandardFileSystemPublishController.java#L21: Rename this class.
5. StandardFileSystemPublishController.java#L331: Rename "publishType" which hides the field declared at line 132.
6. StandardFileSystemPublishController.java#L571: Remove this useless assignment to local variable "error".
7. StandardFileSystemPublishController.java#L21: Add the missing @deprecated annotation.
8. StandardFileSystemPublishController.java#L571: Remove this unused "error" local variable.
9. StandardFileSystemPublishController.java#L621: Remove this use of "ServerLogger"; it is deprecated.
10. StandardFileSystemPublishController.java#L820: Immediately return this expression instead of assigning it to the temporary variable "deltas".

[adietish]

@robstryker I'm fine with this change. Questions remain: don't we need to bump the version? I ack that your solution keeps the class in place extending the API version of it, which ensures no consumer gets broken. +1 for that.

[robstryker]

Version was bumped when 4.5.3 stream began. No need for more bumping.