JBIDE-26598 - fix JMX navigator local processes with JDK9+ Eclipse #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instance targeting a JDK9+ process with JDK9+, there is no management-agent.jar put aside in lib folder of the JDk home. It is available by default. Signed-off-by: Aurélien Pupier <apupier@redhat.com>
|
it would worth adding a test but seems there are not a lot available yet and might require several hours/days of work (unless I missed something?) so given that we are already in code freeze,i provided this PR which is fixing one of the 2 problematic cases when using JMX Navigator with Java 11. |
|
@apupier Great work, I can test your solution. |
apupier
commented
Mar 27, 2019
| @@ -233,20 +234,22 @@ public String getLocalConnectorAddressInternal(Object monitoredVm, int pid) thro | |||
| try { | |||
| virtualMachine = ToolsCore.attach(pid); | |||
|
|
|||
| String javaHome = ToolsCore.getSystemProperties(virtualMachine) | |||
| .getProperty(IConstants.JAVA_HOME_PROPERTY_KEY); | |||
| if(!JavaUtilities.isJigsawRunning()) { | |||
There was a problem hiding this comment.
please note that it would be more accurate if we are checking if jigsaw is running on the targeted vm (it will be required to handle the other problematic use case)
There was a problem hiding this comment.
I created another set of PR to handle it more accurately: jbosstools/jbosstools-base#642 and #620
|
Replaced by #620 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instance targeting a JDK9+ process
with JDK9+, there is no management-agent.jar put aside in lib folder of
the JDk home. It is available by default.
Signed-off-by: Aurélien Pupier apupier@redhat.com