Jbide 26598 fix jmx navigator local j vm with jdk9+everywhere improved withjbosstools common to modify too #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instance targeting a JDK9+ process with JDK9+, there is no management-agent.jar put aside in lib folder of the JDk home. It is available by default. Signed-off-by: Aurélien Pupier <apupier@redhat.com>
instance) Signed-off-by: Aurélien Pupier <apupier@redhat.com>
|
requires jbosstools/jbosstools-base#642 |
…ent agent Signed-off-by: Jeff MAURY <jmaury@redhat.com>
|
When ignoring whitespace, this is a simple 4 line patch. Dead simple, very clean. +1. To be clear I'm not testing this code. But the patches seem extremely clear and I see absolutely nothing wrong with them. If Jeff assures me that the test cases he's run work properly, then I trust him. The code gives me no indication that anything should go wrong here. |
|
testPR |
|
I tried the code locally, and it seems alright. I am gonna give it a try in the morning as well. |
bootclasspath is not supported with Java 11. When selecting a connected process running on Java 11 in JMX Navigator, the if properties view is opened, there was UI popup error. Now it is only logging as Warning waiting for a proper fix. The property in UI will appear blank, without value. Signed-off-by: Aurélien Pupier <apupier@redhat.com>
jeffmaury
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.